From 92f6a1b6bcdb8b27318fef03435ce45d1539a4b5 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Thu, 20 Sep 2018 16:09:05 +0900 Subject: [PATCH] test-process-util: logs something when skipping tests --- src/test/test-process-util.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/test/test-process-util.c b/src/test/test-process-util.c index d396c29..3d63493 100644 --- a/src/test/test-process-util.c +++ b/src/test/test-process-util.c @@ -181,15 +181,19 @@ static void test_get_process_cmdline_harder(void) { _cleanup_free_ char *line = NULL; pid_t pid; - if (geteuid() != 0) + if (geteuid() != 0) { + log_info("Skipping %s: not root", __func__); return; + } #if HAVE_VALGRIND_VALGRIND_H /* valgrind patches open(/proc//cmdline) * so, test_get_process_cmdline_harder fails always * See https://github.com/systemd/systemd/pull/3555#issuecomment-226564908 */ - if (RUNNING_ON_VALGRIND) + if (RUNNING_ON_VALGRIND) { + log_info("Skipping %s: running on valgrind", __func__); return; + } #endif pid = fork(); -- 2.7.4