From 92edc4a7684cdad5d30e197b976c35b2257f7bed Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Fri, 18 Jun 2021 11:08:19 +0100 Subject: [PATCH] libstdc++: Suppress -Wstringop-overread warning in test MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When compiled with -m32 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 we get a warning for 21_strings/basic_string/cons/char/1.cc: bits/char_traits.h:409:56: warning: ‘void* __builtin_memcpy(void*, const void*, unsigned int)’ reading 1073741821 bytes from a region of size 19 [-Wstringop-overread] The warning is legitimate, even if that line cannot be reached because we throw std::length_error before getting there. Since the invalid length is deliberate (and mentioned in a comment) just suppress the warning, so that the test can verify we get the exception. Also remove an unused typedef that produces another warning. libstdc++-v3/ChangeLog: * testsuite/21_strings/basic_string/cons/char/1.cc: Use diagnostic pragma to suppress -Wstringop-overread error. Signed-off-by: Jonathan Wakely --- libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc index 5549094..099921f 100644 --- a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc +++ b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc @@ -36,7 +36,6 @@ using namespace std; void test01(void) { typedef string::size_type csize_type; - typedef string::iterator citerator; csize_type npos = string::npos; csize_type csz01; @@ -68,6 +67,8 @@ void test01(void) // basic_string(const char* s, size_type n, alloc) csz01 = str01.max_size(); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstringop-overread" // NB: As strlen(str_lit01) != csz01, this test is undefined. It // should not crash, but what gets constructed is a bit arbitrary. try { @@ -94,6 +95,7 @@ void test01(void) catch(...) { VERIFY( false ); } +#pragma GCC diagnostic pop // Build a maxsize - 1 lengthed string consisting of all A's try { -- 2.7.4