From 92e3d3c85c64732d5db5ad865afc1158fd40582e Mon Sep 17 00:00:00 2001 From: "verwaest@chromium.org" Date: Mon, 18 Aug 2014 16:52:23 +0000 Subject: [PATCH] Add temporary hack compatible with old delete behavior so we can roll into blink. We'll need to update the broken test. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/483753003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/objects.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/objects.cc b/src/objects.cc index d407f74..ebdc6b7 100644 --- a/src/objects.cc +++ b/src/objects.cc @@ -5041,6 +5041,12 @@ MaybeHandle JSObject::DeleteProperty(Handle object, ? KEEP_INOBJECT_PROPERTIES : CLEAR_INOBJECT_PROPERTIES; Handle holder = it.GetHolder(); + // TODO(verwaest): Remove this temporary compatibility hack when blink + // tests are updated. + if (!holder.is_identical_to(object) && + !(object->IsJSGlobalProxy() && holder->IsJSGlobalObject())) { + return it.isolate()->factory()->true_value(); + } NormalizeProperties(holder, mode, 0); Handle result = DeleteNormalizedProperty(holder, name, delete_mode); -- 2.7.4