From 92e2a17f9b145d35b4a9a2273612d323ccdc9cac Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 8 May 2014 10:10:43 -0600 Subject: [PATCH] minor cleanups in is_dynamic_type I noticed that gdbtypes.c:is_dynamic_type has some unneeded "break"s. This patch cleans up the function a bit, removing those and removing the switch's default case so that the end of the function is a bit clearer. 2014-06-04 Tom Tromey * gdbtypes.c (is_dynamic_type): Remove unneeded "break"s. --- gdb/ChangeLog | 4 ++++ gdb/gdbtypes.c | 10 +++------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8e48f1f..ba04857 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2014-06-04 Tom Tromey + * gdbtypes.c (is_dynamic_type): Remove unneeded "break"s. + +2014-06-04 Tom Tromey + * procfs.c (procfs_attach): Make "args" const. * windows-nat.c (windows_attach): Make "args" const. * nto-procfs.c (procfs_attach): Make "args" const. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 0d7b793..ba35883 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -1625,7 +1625,6 @@ is_dynamic_type (struct type *type) { case TYPE_CODE_RANGE: return !has_static_range (TYPE_RANGE_DATA (type)); - break; case TYPE_CODE_ARRAY: { @@ -1635,14 +1634,11 @@ is_dynamic_type (struct type *type) or the elements it contains have a dynamic contents. */ if (is_dynamic_type (TYPE_INDEX_TYPE (type))) return 1; - else - return is_dynamic_type (TYPE_TARGET_TYPE (type)); - break; + return is_dynamic_type (TYPE_TARGET_TYPE (type)); } - default: - return 0; - break; } + + return 0; } static struct type * -- 2.7.4