From 92e26613c6af2c9ebc959de7d02c18be10cd941b Mon Sep 17 00:00:00 2001 From: Martin Storsjo Date: Mon, 16 Jul 2018 05:42:25 +0000 Subject: [PATCH] [MinGW] Automatically mangle Windows-specific entry points as C This mangles entry points wmain, WinMain, wWinMain or DllMain as C functions, to match the ABI for these functions. We already did the same for these functions in MSVC mode, but we also should do the same in the Itanium ABI. This fixes PR38124. Differential Revision: https://reviews.llvm.org/D49354 llvm-svn: 337146 --- clang/lib/AST/ItaniumMangle.cpp | 12 ++++++++++++ clang/test/CodeGenCXX/mangle-mingw.cpp | 19 +++++++++++++++++++ 2 files changed, 31 insertions(+) create mode 100644 clang/test/CodeGenCXX/mangle-mingw.cpp diff --git a/clang/lib/AST/ItaniumMangle.cpp b/clang/lib/AST/ItaniumMangle.cpp index 6f7efcb..3b99a3d 100644 --- a/clang/lib/AST/ItaniumMangle.cpp +++ b/clang/lib/AST/ItaniumMangle.cpp @@ -592,6 +592,18 @@ bool ItaniumMangleContextImpl::shouldMangleCXXName(const NamedDecl *D) { if (FD->isMain()) return false; + // The Windows ABI expects that we would never mangle "typical" + // user-defined entry points regardless of visibility or freestanding-ness. + // + // N.B. This is distinct from asking about "main". "main" has a lot of + // special rules associated with it in the standard while these + // user-defined entry points are outside of the purview of the standard. + // For example, there can be only one definition for "main" in a standards + // compliant program; however nothing forbids the existence of wmain and + // WinMain in the same translation unit. + if (FD->isMSVCRTEntryPoint()) + return false; + // C++ functions and those whose names are not a simple identifier need // mangling. if (!FD->getDeclName().isIdentifier() || L == CXXLanguageLinkage) diff --git a/clang/test/CodeGenCXX/mangle-mingw.cpp b/clang/test/CodeGenCXX/mangle-mingw.cpp new file mode 100644 index 0000000..90a9826 --- /dev/null +++ b/clang/test/CodeGenCXX/mangle-mingw.cpp @@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -emit-llvm %s -o - -triple=x86_64-w64-mingw32 | FileCheck %s + +int func() { return 0; } +// CHECK-DAG: @_Z4funcv + +int main() { return 0; } +// CHECK-DAG: @main + +int wmain() { return 0; } +// CHECK-DAG: @wmain + +int WinMain() { return 0; } +// CHECK-DAG: @WinMain + +int wWinMain() { return 0; } +// CHECK-DAG: @wWinMain + +int DllMain() { return 0; } +// CHECK-DAG: @DllMain -- 2.7.4