From 922b702bf9d4a27cde8fe08f9bb694b8ca8d94ac Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Sat, 25 Jul 2015 01:19:32 +0000 Subject: [PATCH] [SemaTemplate] Detect instantiation of unparsed exceptions. This fixes the clang crash reported in PR24000. Differential Revision: http://reviews.llvm.org/D11341 llvm-svn: 243196 --- clang/lib/Sema/SemaExceptionSpec.cpp | 8 +++++++- clang/test/SemaTemplate/crash-unparsed-exception.cpp | 17 +++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 clang/test/SemaTemplate/crash-unparsed-exception.cpp diff --git a/clang/lib/Sema/SemaExceptionSpec.cpp b/clang/lib/Sema/SemaExceptionSpec.cpp index 8a93723..ec3d9fd8 100644 --- a/clang/lib/Sema/SemaExceptionSpec.cpp +++ b/clang/lib/Sema/SemaExceptionSpec.cpp @@ -161,7 +161,13 @@ Sema::ResolveExceptionSpec(SourceLocation Loc, const FunctionProtoType *FPT) { else InstantiateExceptionSpec(Loc, SourceDecl); - return SourceDecl->getType()->castAs(); + const FunctionProtoType *Proto = + SourceDecl->getType()->castAs(); + if (Proto->getExceptionSpecType() == clang::EST_Unparsed) { + Diag(Loc, diag::err_exception_spec_not_parsed); + Proto = nullptr; + } + return Proto; } void diff --git a/clang/test/SemaTemplate/crash-unparsed-exception.cpp b/clang/test/SemaTemplate/crash-unparsed-exception.cpp new file mode 100644 index 0000000..1226b35 --- /dev/null +++ b/clang/test/SemaTemplate/crash-unparsed-exception.cpp @@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify -fcxx-exceptions -fexceptions %s + +struct A { + virtual ~A(); +}; +template +struct B {}; +struct C { + template + struct D { + ~D() throw(); + }; + struct E : A { + D d; //expected-error{{exception specification is not available until end of class definition}} + }; + B b; //expected-note{{in instantiation of template class 'B' requested here}} +}; -- 2.7.4