From 9206d8bc96fa4728e0c5291711eb93c7bc1355fd Mon Sep 17 00:00:00 2001 From: Sunwook Bae Date: Wed, 17 Apr 2013 21:15:00 +0900 Subject: [PATCH] Apply secure logs Change-Id: Id4d4569b3667a649f551dfd33a26f1ad7ded28a4 Signed-off-by: Sunwook Bae --- src/FIo_ChannelCAppStub.cpp | 4 ++-- src/FIo_ChannelService.cpp | 12 ++++++------ src/FIo_ChannelServiceStub.cpp | 3 +-- src/FIo_MessagePortService.cpp | 2 +- src/FIo_MessagePortStub.cpp | 6 ++++-- 5 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/FIo_ChannelCAppStub.cpp b/src/FIo_ChannelCAppStub.cpp index 9ac1990..524ac92 100644 --- a/src/FIo_ChannelCAppStub.cpp +++ b/src/FIo_ChannelCAppStub.cpp @@ -254,7 +254,7 @@ _ChannelCAppStub::OnConnectionRequest(GIOChannel* source, GIOCondition condition readSize = read(clientFd, &helloMessage, sizeof(helloMessage)); helloMessage.appId[255] = '\0'; - SysLog(NID_IO, " >> Channel Service: accepted client fd: %d, client pid: %d, appid: %s", + SysLog(NID_IO, " >> Channel Service: accepted client fd: %d, client: %d, app: %s", clientFd, helloMessage.pid, helloMessage.appId); pGIOChannel = g_io_channel_unix_new(clientFd); @@ -454,7 +454,7 @@ _ChannelCAppStub::HandleReceivedMessage(GIOChannel* source, GIOCondition conditi string requestId(buffer.substr(pos, lastPos-pos)); reqId = atol(requestId.c_str()); - SysLog(NID_IO, "CAppChannel >> requestId = %d", reqId); + SysLog(NID_IO, "CAppChannel >> request = %d", reqId); pos = lastPos + tokenStr.length(); diff --git a/src/FIo_ChannelService.cpp b/src/FIo_ChannelService.cpp index bb1e7bc..19a72f9 100644 --- a/src/FIo_ChannelService.cpp +++ b/src/FIo_ChannelService.cpp @@ -155,7 +155,7 @@ _ChannelService::UnregisterChannel(const String& channelId) result _ChannelService::UnregisterChannel(int clientId) { - SysLog(NID_IO, "Unregister - clientId = %d", clientId); + SysLog(NID_IO, "Unregister - client = %d", clientId); result r = E_OBJ_NOT_FOUND; @@ -172,7 +172,7 @@ _ChannelService::UnregisterChannel(int clientId) __channels.GetValue(key, pValue); if (pValue != null && pValue->clientId == clientId) { - SysLog(NID_IO, "Unregister - ChannelId = %ls", key.GetPointer()); + SysLog(NID_IO, "Unregister - Channel = %ls", key.GetPointer()); __channels.Remove(key); delete pValue; @@ -191,7 +191,7 @@ _ChannelService::SendRequest(const String& src, const ArrayList& args, int requestId) { - SysLog(NID_IO, "[%ls] ---> [%ls], Request ID = %d", src.GetPointer(), dest.GetPointer(), requestId); + SysLog(NID_IO, "[%ls] ---> [%ls], Request = %d", src.GetPointer(), dest.GetPointer(), requestId); _ChannelInfo* pChannelInfo = null; @@ -210,7 +210,7 @@ _ChannelService::SendNullRequest(const String& src, const String& dest, int requestId) { - SysLog(NID_IO, "[%ls] ---> [%ls], Request ID = %d", src.GetPointer(), dest.GetPointer(), requestId); + SysLog(NID_IO, "[%ls] ---> [%ls], Request = %d", src.GetPointer(), dest.GetPointer(), requestId); _ChannelInfo* pChannelInfo = null; @@ -229,7 +229,7 @@ _ChannelService::SendResponse(const String& src, const ArrayList& args, int requestId) { - SysLog(NID_IO, "[%ls] ---> [%ls], Request ID = %d", src.GetPointer(), dest.GetPointer(), requestId); + SysLog(NID_IO, "[%ls] ---> [%ls], Request = %d", src.GetPointer(), dest.GetPointer(), requestId); _ChannelInfo* pChannelInfo = null; @@ -258,7 +258,7 @@ _ChannelService::SendNullResponse(const String& src, const String& dest, int requestId) { - SysLog(NID_IO, "[%ls] ---> [%ls], Request ID = %d", src.GetPointer(), dest.GetPointer(), requestId); + SysLog(NID_IO, "[%ls] ---> [%ls], Request = %d", src.GetPointer(), dest.GetPointer(), requestId); _ChannelInfo* pChannelInfo = null; diff --git a/src/FIo_ChannelServiceStub.cpp b/src/FIo_ChannelServiceStub.cpp index 628dff2..9ba2b0c 100644 --- a/src/FIo_ChannelServiceStub.cpp +++ b/src/FIo_ChannelServiceStub.cpp @@ -63,7 +63,6 @@ result _ChannelServiceStub::Construct(void) { SysAssertf(__pIpcServer == null, "Already constructed. Calling Construct() twice or more on a same instance is not allowed for this class."); - SysLog(NID_IO, "Constructed"); result r = E_SUCCESS; _IpcServer* pIpcServer = null; @@ -225,7 +224,7 @@ _ChannelServiceStub::OnIpcClientConnected(const _IpcServer& server, int clientId void _ChannelServiceStub::OnIpcClientDisconnected(const _IpcServer& server, int clientId) { - SysAssertf(__pChannelService != null, "Channel service has not been initialized.\n"); + SysAssertf(__pChannelService != null, "Channel service has not been initialized."); SysLog(NID_IO, "<<<<<<<<<<<<<<<<<<<<<<<<<<<<<"); __pChannelService->UnregisterChannel(clientId); SysLog(NID_IO, ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>"); diff --git a/src/FIo_MessagePortService.cpp b/src/FIo_MessagePortService.cpp index 49ae069..0aa9ee1 100644 --- a/src/FIo_MessagePortService.cpp +++ b/src/FIo_MessagePortService.cpp @@ -85,7 +85,7 @@ _MessagePortService::RegisterMessagePort(int clientId, const BundleBuffer& buffe String key = GetKey(buffer); String trusted(bundle_get_val(b, TRUSTED_LOCAL)); - SysLog(NID_IO, "Register a message port: [%ls], client id = %d", key.GetPointer(), clientId); + SysLog(NID_IO, "Register a message port: [%ls], client = %d", key.GetPointer(), clientId); result r = E_SUCCESS; int value = -1; diff --git a/src/FIo_MessagePortStub.cpp b/src/FIo_MessagePortStub.cpp index d244a9d..5bb8768 100644 --- a/src/FIo_MessagePortStub.cpp +++ b/src/FIo_MessagePortStub.cpp @@ -162,8 +162,10 @@ _MessagePortStub::OnIpcClientConnected(const IpcServer& server, int clientId) void _MessagePortStub::OnIpcClientDisconnected(const IpcServer& server, int clientId) { - SysAssertf(__pService != null, "Channel service has not been initialized.\n"); - SysLog(NID_IO, "Unregister - clientId = %d", clientId); + SysAssertf(__pService != null, "MessagePort service has not been initialized."); + SysLog(NID_IO, "<<<<<<<<<<<<<<<<<<<<<<<<<<<<<"); + SysLog(NID_IO, "Unregister - client = %d", clientId); + SysLog(NID_IO, "<<<<<<<<<<<<<<<<<<<<<<<<<<<<<"); __pService->UnregisterMessagePort(clientId); } -- 2.7.4