From 91fbd04fb99e3dde34a6b950bc8ba3ba9ced4fc1 Mon Sep 17 00:00:00 2001 From: jakub Date: Mon, 11 Jan 2016 17:59:22 +0000 Subject: [PATCH] PR c++/69211 * cp-gimplify.c (cp_fold): If COMPOUND_EXPR or MODIFY_EXPR folded operands have side-effects, but folding changed any of them, build a new tree with the folded operands instead of returning the unfolded tree. * g++.dg/opt/pr69211.C: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@232237 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/cp/ChangeLog | 8 ++++++++ gcc/cp/cp-gimplify.c | 6 +++++- gcc/testsuite/ChangeLog | 3 +++ gcc/testsuite/g++.dg/opt/pr69211.C | 10 ++++++++++ 4 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/opt/pr69211.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 9aedf00..1f12121 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,11 @@ +2016-01-11 Jakub Jelinek + + PR c++/69211 + * cp-gimplify.c (cp_fold): If COMPOUND_EXPR or MODIFY_EXPR + folded operands have side-effects, but folding changed any of them, + build a new tree with the folded operands instead of returning the + unfolded tree. + 2016-01-09 Marek Polacek PR c++/69113 diff --git a/gcc/cp/cp-gimplify.c b/gcc/cp/cp-gimplify.c index 3bc2769..1478802 100644 --- a/gcc/cp/cp-gimplify.c +++ b/gcc/cp/cp-gimplify.c @@ -2086,7 +2086,11 @@ cp_fold (tree x) if ((code == COMPOUND_EXPR || code == MODIFY_EXPR) && ((op1 && TREE_SIDE_EFFECTS (op1)) || (op0 && TREE_SIDE_EFFECTS (op0)))) - break; + { + if (op0 != TREE_OPERAND (x, 0) || op1 != TREE_OPERAND (x, 1)) + x = build2_loc (loc, code, TREE_TYPE (x), op0, op1); + break; + } if (TREE_CODE (x) == COMPOUND_EXPR && !op0) op0 = build_empty_stmt (loc); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 1497f00..9e9423b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2016-01-11 Jakub Jelinek + PR c++/69211 + * g++.dg/opt/pr69211.C: New test. + PR tree-optimization/69214 * gcc.c-torture/compile/pr69214.c: New test. diff --git a/gcc/testsuite/g++.dg/opt/pr69211.C b/gcc/testsuite/g++.dg/opt/pr69211.C new file mode 100644 index 0000000..c3c5b1d --- /dev/null +++ b/gcc/testsuite/g++.dg/opt/pr69211.C @@ -0,0 +1,10 @@ +// PR c++/69211 +// { dg-do compile } + +int a, b; + +int +foo () +{ + return (a & 5UL | (b = 4, 4L)) > 4; +} -- 2.7.4