From 9197e62ce4d2fb2e7b065f90717d45501cd9ac1e Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sun, 19 Apr 2020 04:51:03 +0000 Subject: [PATCH] Fix broken doc links to QuickstartRewrites.md after move under Tutorials --- mlir/docs/Canonicalization.md | 4 ++-- mlir/docs/DeclarativeRewrites.md | 4 ++-- mlir/docs/DialectConversion.md | 2 +- mlir/docs/OpDefinitions.md | 2 +- mlir/docs/PassManagement.md | 6 +++--- mlir/docs/Tutorials/Toy/Ch-5.md | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/mlir/docs/Canonicalization.md b/mlir/docs/Canonicalization.md index 74be61a..8434337 100644 --- a/mlir/docs/Canonicalization.md +++ b/mlir/docs/Canonicalization.md @@ -85,8 +85,8 @@ void MyOp::getCanonicalizationPatterns(OwningRewritePatternList &patterns, } ``` -See the [quickstart guide](QuickstartRewrites.md) for information on defining -operation rewrites. +See the [quickstart guide](Tutorials/QuickstartRewrites.md) for information on +defining operation rewrites. ### Canonicalizing with `fold` diff --git a/mlir/docs/DeclarativeRewrites.md b/mlir/docs/DeclarativeRewrites.md index 2f2299f..83eb354 100644 --- a/mlir/docs/DeclarativeRewrites.md +++ b/mlir/docs/DeclarativeRewrites.md @@ -11,8 +11,8 @@ compiler build time. This manual explains in detail all of the available mechanisms for defining rewrite rules in such a declarative manner. It aims to be a specification instead of a tutorial. Please refer to -[Quickstart tutorial to adding MLIR graph rewrite](QuickstartRewrites.md) for -the latter. +[Quickstart tutorial to adding MLIR graph +rewrite](Tutorials/QuickstartRewrites.md) for the latter. Given that declarative rewrite rules depend on op definition specification, this manual assumes knowledge of the [ODS](OpDefinitions.md) doc. diff --git a/mlir/docs/DialectConversion.md b/mlir/docs/DialectConversion.md index ec02b72..0835527 100644 --- a/mlir/docs/DialectConversion.md +++ b/mlir/docs/DialectConversion.md @@ -152,7 +152,7 @@ After the conversion target has been defined, a set of legalization patterns must be provided to transform illegal operations into legal ones. The patterns supplied here, that do not [require type changes](#conversion-patterns), are the same as those described in the -[quickstart rewrites guide](QuickstartRewrites.md#adding-patterns), but have a +[quickstart rewrites guide](Tutorials/QuickstartRewrites.md#adding-patterns), but have a few additional [restrictions](#restrictions). The patterns provided do not need to generate operations that are directly legal on the target. The framework will automatically build a graph of conversions to convert non-legal operations into diff --git a/mlir/docs/OpDefinitions.md b/mlir/docs/OpDefinitions.md index 11d1533..ad7fd33 100644 --- a/mlir/docs/OpDefinitions.md +++ b/mlir/docs/OpDefinitions.md @@ -10,7 +10,7 @@ equivalent `mlir::Op` C++ template specialization at compiler build time. This manual explains in detail all the available mechanisms for defining operations in such a table-driven manner. It aims to be a specification instead of a tutorial. Please refer to [Quickstart tutorial to adding MLIR graph -rewrite](QuickstartRewrites.md) for the latter. +rewrite](Tutorials/QuickstartRewrites.md) for the latter. In addition to detailing each mechanism, this manual also tries to capture best practices. They are rendered as quoted bullet points. diff --git a/mlir/docs/PassManagement.md b/mlir/docs/PassManagement.md index e807c80..ea3dac6 100644 --- a/mlir/docs/PassManagement.md +++ b/mlir/docs/PassManagement.md @@ -9,9 +9,9 @@ to use it. See [MLIR specification](LangRef.md) for more information about MLIR and its core aspects, such as the IR structure and operations. -See [MLIR Rewrites](QuickstartRewrites.md) for a quick start on graph rewriting -in MLIR. If your transformation involves pattern matching operation DAGs, this -is a great place to start. +See [MLIR Rewrites](Tutorials/QuickstartRewrites.md) for a quick start on graph +rewriting in MLIR. If your transformation involves pattern matching operation +DAGs, this is a great place to start. ## Operation Pass diff --git a/mlir/docs/Tutorials/Toy/Ch-5.md b/mlir/docs/Tutorials/Toy/Ch-5.md index 28e799d..67fc0f6 100644 --- a/mlir/docs/Tutorials/Toy/Ch-5.md +++ b/mlir/docs/Tutorials/Toy/Ch-5.md @@ -39,7 +39,7 @@ framework, we need to provide two things (and an optional third): * A set of [Rewrite Patterns](../../DialectConversion.md#rewrite-pattern-specification) - - This is the set of [patterns](../../QuickstartRewrites.md) used to + - This is the set of [patterns](../QuickstartRewrites.md) used to convert *illegal* operations into a set of zero or more *legal* ones. * Optionally, a [Type Converter](../../DialectConversion.md#type-conversion). @@ -86,7 +86,7 @@ After the conversion target has been defined, we can define how to convert the *illegal* operations into *legal* ones. Similarly to the canonicalization framework introduced in [chapter 3](Ch-3.md), the [`DialectConversion` framework](../../DialectConversion.md) also uses -[RewritePatterns](../../QuickstartRewrites.md) to perform the conversion logic. +[RewritePatterns](../QuickstartRewrites.md) to perform the conversion logic. These patterns may be the `RewritePatterns` seen before or a new type of pattern specific to the conversion framework `ConversionPattern`. `ConversionPatterns` are different from traditional `RewritePatterns` in that they accept an -- 2.7.4