From 916aebabb83745dd7b1402a92f120107fa6ea6b6 Mon Sep 17 00:00:00 2001 From: isaacs Date: Fri, 1 Feb 2013 15:55:03 -0800 Subject: [PATCH] debugger: Make the debugger timeout configurable If the NODE_DEBUGGER_TIMEOUT environment variable is set, then use that as the number of ms to wait for the debugger to start. This is primarily to work around a race condition that almost never happens in real usage with the debugger, but happens EVERY FRACKING TIME when the debugger tests run as part of 'make test'. --- src/node.js | 3 ++- test/simple/test-debugger-client.js | 1 + test/simple/test-debugger-repl-utf8.js | 1 + test/simple/test-debugger-repl.js | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/node.js b/src/node.js index 9fc68e4..64a8889 100644 --- a/src/node.js +++ b/src/node.js @@ -111,7 +111,8 @@ // global.v8debug object about a connection, and runMain when // that occurs. --isaacs - setTimeout(Module.runMain, 50); + var debugTimeout = +process.env.NODE_DEBUG_TIMEOUT || 50; + setTimeout(Module.runMain, debugTimeout); } else { // REMOVEME: nextTick should not be necessary. This hack to get diff --git a/test/simple/test-debugger-client.js b/test/simple/test-debugger-client.js index 5102a7b..70606be 100644 --- a/test/simple/test-debugger-client.js +++ b/test/simple/test-debugger-client.js @@ -22,6 +22,7 @@ +process.env.NODE_DEBUGGER_TIMEOUT = 200; var common = require('../common'); var assert = require('assert'); var debug = require('_debugger'); diff --git a/test/simple/test-debugger-repl-utf8.js b/test/simple/test-debugger-repl-utf8.js index 720410d..a46075e 100644 --- a/test/simple/test-debugger-repl-utf8.js +++ b/test/simple/test-debugger-repl-utf8.js @@ -20,6 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. +process.env.NODE_DEBUGGER_TIMEOUT = 200; var common = require('../common'); var assert = require('assert'); var spawn = require('child_process').spawn; diff --git a/test/simple/test-debugger-repl.js b/test/simple/test-debugger-repl.js index fb06441..01e3ef7 100644 --- a/test/simple/test-debugger-repl.js +++ b/test/simple/test-debugger-repl.js @@ -20,6 +20,7 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. +process.env.NODE_DEBUGGER_TIMEOUT = 200; var common = require('../common'); var assert = require('assert'); var spawn = require('child_process').spawn; -- 2.7.4