From 911fe9136781fa8e77e83efb575d7a9ab717fb37 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Wed, 28 Sep 2011 02:30:27 +0000 Subject: [PATCH] Implement a PageTransitionEvent constructor for V8 https://bugs.webkit.org/show_bug.cgi?id=68067 Patch by Kentaro Hara on 2011-09-27 Reviewed by Adam Barth. Source/WebCore: Test: fast/events/constructors/page-transition-event-constructor.html * bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor. * dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute. LayoutTests: Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96180 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 11 +++++++++++ LayoutTests/platform/chromium/test_expectations.txt | 3 --- Source/WebCore/ChangeLog | 12 ++++++++++++ Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp | 3 +++ Source/WebCore/dom/PageTransitionEvent.idl | 3 ++- 5 files changed, 28 insertions(+), 4 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 4174eb5..fac0dde 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,14 @@ +2011-09-27 Kentaro Hara + + Implement a PageTransitionEvent constructor for V8 + https://bugs.webkit.org/show_bug.cgi?id=68067 + + Reviewed by Adam Barth. + + Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor. + + * platform/chromium/test_expectations.txt: + 2011-09-27 Kentaro Hara Implement a MessageEvent constructor for JSC diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt index 3a13a9d..ef2ad49 100644 --- a/LayoutTests/platform/chromium/test_expectations.txt +++ b/LayoutTests/platform/chromium/test_expectations.txt @@ -74,9 +74,6 @@ BUGCR84572 SKIP : storage/storageinfo-no-callbacks.html = FAIL // to re-enable these "in the next few weeks". BUGPKASTING SKIP : animations/animation-api-1.html = TEXT -// This will soon be fixed after implementing a PageTransitionEvent constructor for V8. -BUGWK68048 : fast/events/constructors/page-transition-event-constructor.html = FAIL - // Unskip after implementing DRT support for setDefersLoading and goBack. BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL BUGWK60877 SKIP : loader/load-defer-resume-crash.html = FAIL diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index fe437c1..4554567 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,15 @@ +2011-09-27 Kentaro Hara + + Implement a PageTransitionEvent constructor for V8 + https://bugs.webkit.org/show_bug.cgi?id=68067 + + Reviewed by Adam Barth. + + Test: fast/events/constructors/page-transition-event-constructor.html + + * bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor. + * dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute. + 2011-09-27 Kentaro Hara Implement a MessageEvent constructor for JSC diff --git a/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp b/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp index 58dc4a4..99f7a5a 100644 --- a/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp +++ b/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp @@ -37,6 +37,7 @@ #include "DocumentFragment.h" #include "HashChangeEvent.h" #include "Node.h" +#include "PageTransitionEvent.h" #include "ProgressEvent.h" #include "WebKitAnimationEvent.h" @@ -49,6 +50,7 @@ #include "V8Event.h" #include "V8HashChangeEvent.h" #include "V8Node.h" +#include "V8PageTransitionEvent.h" #include "V8ProgressEvent.h" #include "V8Proxy.h" #include "V8WebKitAnimationEvent.h" @@ -111,6 +113,7 @@ INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PROGRESS_EVENT(DICTIONARY_START, DICTIO INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CLOSE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) +INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) } // namespace WebCore diff --git a/Source/WebCore/dom/PageTransitionEvent.idl b/Source/WebCore/dom/PageTransitionEvent.idl index dab23ae..90f31e5 100644 --- a/Source/WebCore/dom/PageTransitionEvent.idl +++ b/Source/WebCore/dom/PageTransitionEvent.idl @@ -27,7 +27,8 @@ module events { interface [ CanBeConstructed, - CustomConstructFunction + CustomConstructFunction, + V8CustomConstructor ] PageTransitionEvent : Event { readonly attribute boolean persisted; -- 2.7.4