From 90e3e630c2f641f3ceca32672e8e3a8ac0ceae8a Mon Sep 17 00:00:00 2001 From: David Sterba Date: Wed, 21 Sep 2016 13:36:04 +0200 Subject: [PATCH] btrfs-progs: mkfs: fix reading rotational status value ASAN reports that we're reading beyond the bounds, and is right. The variable is too short to store a nonempty string for atoi. Signed-off-by: David Sterba --- mkfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mkfs.c b/mkfs.c index b33e368..adfc278 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1193,13 +1193,13 @@ static int is_ssd(const char *file) return 0; } - if (read(fd, &rotational, sizeof(char)) < sizeof(char)) { + if (read(fd, &rotational, 1) < 1) { close(fd); return 0; } close(fd); - return !atoi((const char *)&rotational); + return rotational == '0'; } static int _cmp_device_by_id(void *priv, struct list_head *a, -- 2.7.4