From 907ace57986733add2aebfa9dd7c83c67efed70e Mon Sep 17 00:00:00 2001 From: Jonathan Gray Date: Sat, 22 Oct 2016 18:19:53 +1100 Subject: [PATCH] mapi: automake: set VISIBILITY_CFLAGS for shared glapi shared glapi was previously built without setting CFLAGS for AM_CFLAGS and VISIBILITY_CFLAGS. This resulted in symbols being exported that shouldn't be. The x86 and sparc assembly versions of the dispatch table partially mitigated this by using .hidden. Otherwise shared_dispatch_stub_* were being exported. Signed-off-by: Jonathan Gray Cc: "11.2 12.0 13.0" Reviewed-by: Emil Velikov Reviewed-by: Eric Engestrom --- src/mapi/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mapi/Makefile.am b/src/mapi/Makefile.am index 46afe3b..5013e9a 100644 --- a/src/mapi/Makefile.am +++ b/src/mapi/Makefile.am @@ -64,6 +64,9 @@ BUILT_SOURCES += shared-glapi/glapi_mapi_tmp.h lib_LTLIBRARIES += shared-glapi/libglapi.la shared_glapi_libglapi_la_SOURCES = $(MAPI_GLAPI_FILES) shared-glapi/glapi_mapi_tmp.h +shared_glapi_libglapi_la_CFLAGS = \ + $(AM_CFLAGS) \ + $(VISIBILITY_CFLAGS) shared_glapi_libglapi_la_CPPFLAGS = \ $(AM_CPPFLAGS) \ -DMAPI_MODE_GLAPI \ -- 2.7.4