From 903ae060db90aa1d72aa67afbc5a5ecabdcdbef7 Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Mon, 28 Jan 2013 17:51:03 +0100 Subject: [PATCH] Don't use GLIBC_PRIVATE errno outside of libraries --- ChangeLog | 7 +++++++ NEWS | 4 ++-- elf/tst-stackguard1.c | 1 + include/errno.h | 4 ++-- include/netdb.h | 22 ++++++++++++---------- nptl/ChangeLog | 8 ++++++++ nptl/tst-cancel14.c | 1 + nptl/tst-cancel15.c | 1 + nptl/tst-mutex9.c | 3 +++ nptl/tst-stackguard1.c | 1 + 10 files changed, 38 insertions(+), 14 deletions(-) diff --git a/ChangeLog b/ChangeLog index 74b9a59..0c19491 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-02-04 Andreas Schwab + + [BZ #14142] + * include/errno.h: Redefine errno only if !NOT_IN_libc || IN_LIB. + * include/netdb.h: Likewise for h_errno. + * elf/tst-stackguard1.c: Include . + 2013-02-02 Jan Kratochvil * elf/link.h (struct link_map): Extend the l_addr comment. diff --git a/NEWS b/NEWS index 8c21790..b5c465d 100644 --- a/NEWS +++ b/NEWS @@ -9,8 +9,8 @@ Version 2.18 * The following bugs are resolved with this release: - 13951, 14200, 14317, 14327, 14496, 14964, 14981, 14982, 14985, 14994, - 14996, 15003, 15020, 15023, 15036, 15062. + 13951, 14142, 14200, 14317, 14327, 14496, 14964, 14981, 14982, 14985, + 14994, 14996, 15003, 15020, 15023, 15036, 15062. Version 2.17 diff --git a/elf/tst-stackguard1.c b/elf/tst-stackguard1.c index 2b4fd9a..fba60bd 100644 --- a/elf/tst-stackguard1.c +++ b/elf/tst-stackguard1.c @@ -23,6 +23,7 @@ #include #include #include +#include #include static const char *command; diff --git a/include/errno.h b/include/errno.h index 98c6080..f1b93a8 100644 --- a/include/errno.h +++ b/include/errno.h @@ -17,7 +17,7 @@ # define errno rtld_errno extern int rtld_errno attribute_hidden; -# else +# elif !defined NOT_IN_libc || defined IN_LIB # include @@ -29,7 +29,7 @@ extern int rtld_errno attribute_hidden; # endif extern __thread int errno attribute_tls_model_ie; -# endif /* RTLD_PRIVATE_ERRNO */ +# endif /* !NOT_IN_libc || IN_LIB */ # define __set_errno(val) (errno = (val)) diff --git a/include/netdb.h b/include/netdb.h index 3f2ae06..8a569ba 100644 --- a/include/netdb.h +++ b/include/netdb.h @@ -3,18 +3,20 @@ #ifndef _ISOMAC /* Macros for accessing h_errno from inside libc. */ -# undef h_errno -# ifdef _LIBC_REENTRANT -# include -# ifndef NOT_IN_libc -# define h_errno __libc_h_errno -# else -# define h_errno h_errno /* For #ifndef h_errno tests. */ -# endif +# if !defined NOT_IN_libc || defined IN_LIB +# undef h_errno +# ifdef _LIBC_REENTRANT +# include +# ifndef NOT_IN_libc +# define h_errno __libc_h_errno +# else +# define h_errno h_errno /* For #ifndef h_errno tests. */ +# endif extern __thread int h_errno attribute_tls_model_ie; -# else +# else extern int h_errno; -# endif /* _LIBC_REENTRANT */ +# endif /* _LIBC_REENTRANT */ +# endif /* !NOT_IN_libc || IN_LIB */ # define __set_h_errno(x) (h_errno = (x)) libc_hidden_proto (hstrerror) diff --git a/nptl/ChangeLog b/nptl/ChangeLog index c4f6c63..bcc1660 100644 --- a/nptl/ChangeLog +++ b/nptl/ChangeLog @@ -1,3 +1,11 @@ +2013-02-04 Andreas Schwab + + [BZ #14142] + * tst-cancel14.c: Include . + * tst-cancel15.c: Likewise. + * tst-mutex9.c: Include , and . + * tst-stackguard1.c: Include + 2013-01-16 Andreas Schwab [BZ #14327] diff --git a/nptl/tst-cancel14.c b/nptl/tst-cancel14.c index fbaed49..ca9042d 100644 --- a/nptl/tst-cancel14.c +++ b/nptl/tst-cancel14.c @@ -23,6 +23,7 @@ #include #include #include +#include static pthread_barrier_t bar; diff --git a/nptl/tst-cancel15.c b/nptl/tst-cancel15.c index 0119cc7..3f320ad 100644 --- a/nptl/tst-cancel15.c +++ b/nptl/tst-cancel15.c @@ -23,6 +23,7 @@ #include #include #include +#include static pthread_barrier_t bar; diff --git a/nptl/tst-mutex9.c b/nptl/tst-mutex9.c index adb3b61..1d689bd 100644 --- a/nptl/tst-mutex9.c +++ b/nptl/tst-mutex9.c @@ -18,10 +18,13 @@ #include #include +#include #include +#include #include #include #include +#include #include diff --git a/nptl/tst-stackguard1.c b/nptl/tst-stackguard1.c index f0f707f..57a48ad 100644 --- a/nptl/tst-stackguard1.c +++ b/nptl/tst-stackguard1.c @@ -24,6 +24,7 @@ #include #include #include +#include #include static const char *command; -- 2.7.4