From 90344499ae76dffa56363e2f167c2c34a76cbfaf Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Thu, 3 Jun 2021 19:58:43 +0100 Subject: [PATCH] [lld-macho] Fix BUILD_SHARED_LIBS build ca6751043d8899b12baeb48621e61fb352cfee09 added a dependency on XAR (at least for the shared libs build), so without this change we get the following linker error: Undefined symbols for architecture x86_64: "_xar_close", referenced from: lld::macho::BitcodeBundleSection::finalize() in SyntheticSections.cpp.o Reviewed By: #lld-macho, int3, thakis Differential Revision: https://reviews.llvm.org/D100999 --- lld/MachO/CMakeLists.txt | 4 ++++ lld/tools/lld/CMakeLists.txt | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lld/MachO/CMakeLists.txt b/lld/MachO/CMakeLists.txt index a805e17..61ac878 100644 --- a/lld/MachO/CMakeLists.txt +++ b/lld/MachO/CMakeLists.txt @@ -55,3 +55,7 @@ add_lld_library(lldMachO2 MachOOptionsTableGen ${tablegen_deps} ) + +if(LLVM_HAVE_LIBXAR) + target_link_libraries(lldMachO2 PRIVATE ${XAR_LIB}) +endif() diff --git a/lld/tools/lld/CMakeLists.txt b/lld/tools/lld/CMakeLists.txt index 738f484..e77b216 100644 --- a/lld/tools/lld/CMakeLists.txt +++ b/lld/tools/lld/CMakeLists.txt @@ -20,10 +20,6 @@ target_link_libraries(lld lldWasm ) -if(LLVM_HAVE_LIBXAR) - target_link_libraries(lld PRIVATE ${XAR_LIB}) -endif() - install(TARGETS lld RUNTIME DESTINATION bin) -- 2.7.4