From 9005428910546de2e1ad61e55a5fad7fdd514c44 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Sat, 10 Oct 2015 10:51:10 +0100 Subject: [PATCH] validate: fix double free Summary: Move variable declarations in the for block so we won't try re-free tldir in case of early short circuiting of the 'for' code. Depends on D348 Reviewers: thiblahute Reviewed By: thiblahute Differential Revision: https://phabricator.freedesktop.org/D349 --- validate/gst/validate/gst-validate-scenario.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/validate/gst/validate/gst-validate-scenario.c b/validate/gst/validate/gst-validate-scenario.c index e620649..8886ce1 100644 --- a/validate/gst/validate/gst-validate-scenario.c +++ b/validate/gst/validate/gst-validate-scenario.c @@ -2303,7 +2303,6 @@ gst_validate_scenario_load (GstValidateScenario * scenario, { gchar **scenarios = NULL; guint i; - gchar *lfilename = NULL, *tldir = NULL; gboolean found_actions = FALSE, is_config, ret = TRUE; const gchar *scenarios_path = g_getenv ("GST_VALIDATE_SCENARIOS_PATH"); @@ -2316,6 +2315,7 @@ gst_validate_scenario_load (GstValidateScenario * scenario, scenarios = g_strsplit (scenario_name, ":", -1); for (i = 0; scenarios[i]; i++) { + gchar *lfilename = NULL, *tldir = NULL; /* First check if the scenario name is not a full path to the * actual scenario */ -- 2.7.4