From 8fb86011026c56204e54a2806d598249c6297d08 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 16 Sep 2021 17:47:34 -0300 Subject: [PATCH] Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails" This reverts commit 47dd1f642846d476e3d789f4aa941699dc0ed3fe. After discussing with Jim Ingham, we agreed to leave the test as-is so we can catch any CI problems instead of silently skipping the test. --- lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py b/lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py index 1230af9..0194234 100644 --- a/lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py +++ b/lldb/test/API/tools/lldb-server/TestAppleSimulatorOSType.py @@ -20,16 +20,7 @@ class TestAppleSimulatorOSType(gdbremote_testcase.GdbRemoteTestCaseBase): cmd = ['xcrun', 'simctl', 'list', '-j', 'devices'] self.trace(' '.join(cmd)) sim_devices_str = subprocess.check_output(cmd).decode("utf-8") - - # xcodebuild, which is invoked by the apple_simulator_test decorator, - # may return a successful status even if it was unable to run due to - # the authorization agent denying it. Try to parse the json that lists - # the simulators but if that fails skip the test. - try: - sim_devices = json.loads(sim_devices_str)['devices'] - except json.decoder.JSONDecodeError: - self.skipTest("Could not parse JSON of simulators available") - + sim_devices = json.loads(sim_devices_str)['devices'] # Find an available simulator for the requested platform deviceUDID = None deviceRuntime = None -- 2.7.4