From 8fa8ca8b1aec464fee17c571c7ba5c7e87d68e10 Mon Sep 17 00:00:00 2001 From: "dcarney@chromium.org" Date: Mon, 9 Sep 2013 10:10:26 +0000 Subject: [PATCH] temporarily remove persistent destructor to allow trunk push TBR=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/24023004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16590 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- include/v8.h | 6 +++--- test/cctest/test-api.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/v8.h b/include/v8.h index 004420c..11aa473 100644 --- a/include/v8.h +++ b/include/v8.h @@ -549,9 +549,9 @@ template class Persistent { * kResetInDestructor flags in the traits class. Since not calling dispose * can result in a memory leak, it is recommended to always set this flag. */ - V8_INLINE(~Persistent()) { - if (M::kResetInDestructor) Reset(); - } +// V8_INLINE(~Persistent()) { +// if (M::kResetInDestructor) Reset(); +// } /** * If non-empty, destroy the underlying storage cell diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc index 19f3309..aaac486 100644 --- a/test/cctest/test-api.cc +++ b/test/cctest/test-api.cc @@ -12700,7 +12700,7 @@ TEST(CopyablePersistent) { CHECK_EQ(initial_handles + 3, globals->global_handles_count()); } // Verify autodispose - CHECK_EQ(initial_handles, globals->global_handles_count()); +// CHECK_EQ(initial_handles, globals->global_handles_count()); } -- 2.7.4