From 8f2f3aa47379d9437925c11f8e560a479a67da93 Mon Sep 17 00:00:00 2001
From: =?utf8?q?K=C3=A9vin=20THIERRY?= <kevin.thierry@open.eurogiciel.org>
Date: Thu, 2 Oct 2014 14:38:50 +0200
Subject: [PATCH] Packaging: improve rpmlint score
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Change-Id: If65bf9ab95ee10fe7d5d923ed1104ee5b9834360
Signed-off-by: Kévin THIERRY <kevin.thierry@open.eurogiciel.org>
---
 packaging/pulseaudio-module-murphy-ivi.spec | 31 ++++++++++++++---------------
 1 file changed, 15 insertions(+), 16 deletions(-)

diff --git a/packaging/pulseaudio-module-murphy-ivi.spec b/packaging/pulseaudio-module-murphy-ivi.spec
index 81045e3..1f973c3 100644
--- a/packaging/pulseaudio-module-murphy-ivi.spec
+++ b/packaging/pulseaudio-module-murphy-ivi.spec
@@ -1,12 +1,11 @@
-Summary: Pulseaudio module for enforcing policy decisions in the audio domain
-Name: pulseaudio-module-murphy-ivi
+Summary:  Pulseaudio module for enforcing policy decisions in the audio domain
+Name:     pulseaudio-module-murphy-ivi
 Version:  0.9.29
-Release: 0
-License: LGPLv2.1
-Group: System Environment/Daemons
-URL: https://github.com/otcshare/pulseaudio-module-murphy-ivi
-Source0: %{name}-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
+Release:  0
+License:  LGPL-2.1
+Group:    Automotive/Resource Policy
+URL:      https://github.com/otcshare/pulseaudio-module-murphy-ivi
+Source0:  %{name}-%{version}.tar.gz
 BuildRequires: pkgconfig(pulseaudio-module-devel)
 BuildRequires: pkgconfig(libpulse)
 BuildRequires: pkgconfig(murphy-common)
@@ -15,6 +14,7 @@ BuildRequires: pkgconfig(murphy-lua-utils)
 BuildRequires: pkgconfig(lua)
 BuildRequires: pkgconfig(dbus-1)
 BuildRequires: pkgconfig(glib-2.0)
+BuildRequires: pkgconfig
 BuildRequires: libtool-ltdl-devel
 Buildrequires: pkgconfig(json)
 BuildRequires: config(pulseaudio)
@@ -22,11 +22,10 @@ BuildRequires: pulseaudio >= 5.0
 BuildRequires: pkgconfig(murphy-pulse)
 BuildRequires: murphy-pulse
 BuildRequires: pkgconfig(aul)
-Requires: pulseaudio >= 5.0
-Requires: aul
-Conflicts: pulseaudio-module-combine-sink
-Conflicts: pulseaudio-module-augment-properties
-
+Requires:      pulseaudio >= 5.0
+Requires:      aul
+Conflicts:     pulseaudio-module-combine-sink
+Conflicts:     pulseaudio-module-augment-properties
 
 %description
 This package contains a pulseaudio module that enforces (mostly audio) routing,
@@ -46,14 +45,13 @@ unset LD_AS_NEEDED
 --with-dbus \
 --with-documentation=no \
 --with-murphyif
-make
+%__make
 
 %install
 rm -rf $RPM_BUILD_ROOT
 %make_install
 rm -f %{_libdir}/pulse-*/modules/module-*.la
 
-
 %clean
 rm -rf $RPM_BUILD_ROOT
 
@@ -64,5 +62,6 @@ rm -rf $RPM_BUILD_ROOT
 %files
 %defattr(-,root,root,-)
 %{_libdir}/pulse-*/modules/module-*.so
-%{_sysconfdir}/dbus-1/system.d/pulseaudio-murphy-ivi.conf
+%config %{_sysconfdir}/dbus-1/system.d/pulseaudio-murphy-ivi.conf
 %{_sysconfdir}/pulse/murphy-ivi.lua
+%license COPYING
-- 
2.7.4