From 8f0b2ac140c36f37597deef66bea8a7739c18a7b Mon Sep 17 00:00:00 2001 From: Joe Loser Date: Mon, 7 Feb 2022 21:33:11 -0500 Subject: [PATCH] [libc++] Use _LIBCPP_NO_UNIQUE_ADDRESS for base in join_view Despite the comment saying `[[no_unique_address]]` on the `__base_` data member makes clang crash, this does not seem to be true on CI. So, mark `__base_` with `_LIBCPP_NO_UNIQUE_ADDRESS`. Differential Revision: https://reviews.llvm.org/D119208 --- libcxx/include/__ranges/join_view.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcxx/include/__ranges/join_view.h b/libcxx/include/__ranges/join_view.h index 1af2221..4bab8df 100644 --- a/libcxx/include/__ranges/join_view.h +++ b/libcxx/include/__ranges/join_view.h @@ -68,7 +68,7 @@ namespace ranges { static constexpr bool _UseCache = !is_reference_v<_InnerRange>; using _Cache = _If<_UseCache, __non_propagating_cache>, __empty_cache>; _LIBCPP_NO_UNIQUE_ADDRESS _Cache __cache_; - _View __base_ = _View(); // TODO: [[no_unique_address]] makes clang crash! File a bug :) + _LIBCPP_NO_UNIQUE_ADDRESS _View __base_ = _View(); public: _LIBCPP_HIDE_FROM_ABI -- 2.7.4