From 8ef389036efce96f721c4a62550c2af818048cfd Mon Sep 17 00:00:00 2001 From: MyungJoo Ham Date: Mon, 13 Jul 2020 16:17:15 +0900 Subject: [PATCH] [Fix/SVACE] memory leak and un-init local variables SVACE reported issues in Tizen CAPI unit test cases: - 443268 (uninitialized local variable) - 443269 (uninitialized local variable) - 443278 (memory leak): although this is always not allocated successully, I've added "free" that fails with its error code assertion. Signed-off-by: MyungJoo Ham --- tests/tizen_capi/unittest_tizen_capi.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/tizen_capi/unittest_tizen_capi.cc b/tests/tizen_capi/unittest_tizen_capi.cc index ea8ce85..7e0545e 100644 --- a/tests/tizen_capi/unittest_tizen_capi.cc +++ b/tests/tizen_capi/unittest_tizen_capi.cc @@ -2111,7 +2111,7 @@ TEST (nnstreamer_capi_util, data_create_n) { int status; ml_tensors_info_h info; - ml_tensors_data_h data; + ml_tensors_data_h data = nullptr; status = ml_tensors_info_create (&info); ASSERT_EQ (status, ML_ERROR_NONE); @@ -2128,6 +2128,9 @@ TEST (nnstreamer_capi_util, data_create_n) status = ml_tensors_info_destroy (info); ASSERT_EQ (status, ML_ERROR_NONE); + + status = ml_tensors_data_destroy (data); + EXPECT_EQ (status, ML_ERROR_INVALID_PARAMETER); } /** @@ -3570,7 +3573,7 @@ TEST (nnstreamer_capi_singleshot, set_input_info_success_01) { ml_single_h single; ml_tensors_info_h in_info, out_info; - ml_tensors_info_h in_res, out_res; + ml_tensors_info_h in_res = nullptr, out_res = nullptr; ml_tensors_data_h input, output; ml_tensor_dimension in_dim, out_dim, res_dim; ml_tensor_type_e type = ML_TENSOR_TYPE_UNKNOWN; @@ -4774,7 +4777,7 @@ TEST (nnstreamer_capi_singleshot, set_input_info_success_02) NNSTREAMER_SO_FILE_EXTENSION; ml_single_h single; ml_tensors_info_h in_info, out_info; - ml_tensors_info_h in_res, out_res; + ml_tensors_info_h in_res = nullptr, out_res = nullptr; ml_tensors_data_h input, output; ml_tensor_dimension in_dim, out_dim, res_dim; ml_tensor_type_e type = ML_TENSOR_TYPE_UNKNOWN; -- 2.7.4