From 8ee6f0c30f460ffe09d3c9d47d1ee1efdac82a6a Mon Sep 17 00:00:00 2001 From: Dmitry Vyukov Date: Fri, 28 Oct 2016 20:52:22 +0000 Subject: [PATCH] tsan: set disable_coredump=0 by default for Go Go maps shadow memory lazily, so we don't have the huge multi-TB mapping. Virtual memory consumption is proportional to normal memory usage. Also in Go core dumps are enabled explicitly with GOTRACEBACK=crash, if user explicitly requests a core that must be on purpose. So don't disable core dumps by default. llvm-svn: 285451 --- compiler-rt/lib/sanitizer_common/sanitizer_flags.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_flags.inc b/compiler-rt/lib/sanitizer_common/sanitizer_flags.inc index 685e29b..f94d151 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_flags.inc +++ b/compiler-rt/lib/sanitizer_common/sanitizer_flags.inc @@ -154,7 +154,7 @@ COMMON_FLAG(bool, full_address_space, false, COMMON_FLAG(bool, print_suppressions, true, "Print matched suppressions at exit.") COMMON_FLAG( - bool, disable_coredump, (SANITIZER_WORDSIZE == 64), + bool, disable_coredump, (SANITIZER_WORDSIZE == 64) && !SANITIZER_GO, "Disable core dumping. By default, disable_coredump=1 on 64-bit to avoid" " dumping a 16T+ core file. Ignored on OSes that don't dump core by" " default and for sanitizers that don't reserve lots of virtual memory.") -- 2.7.4