From 8ec69574031bb8e0a19cf318c093acc871abd965 Mon Sep 17 00:00:00 2001 From: Jiri Pirko Date: Thu, 28 Dec 2017 16:52:10 +0100 Subject: [PATCH] net: sched: don't set extack message in case the qdisc will be created If the qdisc is not found here, it is going to be created. Therefore, this is not an error path. Remove the extack message set and don't confuse user with error message in case the qdisc was created successfully. Fixes: 09215598119e ("net: sched: sch_api: handle generic qdisc errors") Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller --- net/sched/sch_api.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 3a3a1da..81ecf5b 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1402,10 +1402,8 @@ replay: return -EINVAL; } q = qdisc_lookup(dev, tcm->tcm_handle); - if (!q) { - NL_SET_ERR_MSG(extack, "No qdisc found for specified handle"); + if (!q) goto create_n_graft; - } if (n->nlmsg_flags & NLM_F_EXCL) { NL_SET_ERR_MSG(extack, "Exclusivity flag on, cannot override"); return -EEXIST; -- 2.7.4