From 8eb5ba583cb97c10208c82da0ad8073009fb7a71 Mon Sep 17 00:00:00 2001 From: Shaurya Gupta Date: Wed, 31 Jul 2019 10:08:29 +0000 Subject: [PATCH] [Clangd] NFC: Added FIXME in ExtractVariable tests llvm-svn: 367406 --- clang-tools-extra/clangd/unittests/TweakTests.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/clangd/unittests/TweakTests.cpp b/clang-tools-extra/clangd/unittests/TweakTests.cpp index ce1d11d..8662631 100644 --- a/clang-tools-extra/clangd/unittests/TweakTests.cpp +++ b/clang-tools-extra/clangd/unittests/TweakTests.cpp @@ -419,6 +419,11 @@ TEST(TweakTest, ExtractVariable) { void f(int a) { PLUS([[1+a]]); })cpp", + /*FIXME: It should be extracted like this. + R"cpp(#define PLUS(x) x++ + void f(int a) { + auto dummy = 1+a; int y = PLUS(dummy); + })cpp"},*/ R"cpp(#define PLUS(x) x++ void f(int a) { auto dummy = PLUS(1+a); dummy; @@ -429,9 +434,9 @@ TEST(TweakTest, ExtractVariable) { if(1) LOOP(5 + [[3]]) })cpp", - /*FIXME: It should be extracted like this. SelectionTree needs to be + /*FIXME: It should be extracted like this. SelectionTree needs to be * fixed for macros. - R"cpp(#define LOOP(x) while (1) {a = x;} + R"cpp(#define LOOP(x) while (1) {a = x;} void f(int a) { auto dummy = 3; if(1) LOOP(5 + dummy) -- 2.7.4