From 8eb246d7f6137c6d1783c187d37e415e61211d2d Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Wed, 14 Oct 2020 16:25:31 -0700 Subject: [PATCH] v3dv: Remove unsigned comparison to zero. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit index is of type uint32_t. Fix defect reported by Coverity Scan. Macro compares unsigned to 0 (NO_EFFECT) unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. index >= 0U. Signed-off-by: Vinson Lee Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/broadcom/vulkan/v3dv_descriptor_set.c b/src/broadcom/vulkan/v3dv_descriptor_set.c index 41754bd..89657ce 100644 --- a/src/broadcom/vulkan/v3dv_descriptor_set.c +++ b/src/broadcom/vulkan/v3dv_descriptor_set.c @@ -88,7 +88,7 @@ v3dv_descriptor_map_get_descriptor(struct v3dv_descriptor_state *descriptor_stat uint32_t index, uint32_t *dynamic_offset) { - assert(index >= 0 && index < map->num_desc); + assert(index < map->num_desc); uint32_t set_number = map->set[index]; assert((descriptor_state->valid & 1 << set_number)); -- 2.7.4