From 8e207e4c096e89fa5410b519715aba8c20701061 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 8 Aug 2022 21:33:09 -0700 Subject: [PATCH] [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue} MapEntryOptionalStorage is an underlying storage class for OptionalStorage. This patch deprecates: OptionalStorage::hasValue OptionalStorage::getValue as there is no known users of these two methods. Differential Revision: https://reviews.llvm.org/D131368 --- clang/include/clang/Basic/DirectoryEntry.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/clang/include/clang/Basic/DirectoryEntry.h b/clang/include/clang/Basic/DirectoryEntry.h index fe5ec95..f1ec63d 100644 --- a/clang/include/clang/Basic/DirectoryEntry.h +++ b/clang/include/clang/Basic/DirectoryEntry.h @@ -131,13 +131,15 @@ public: void reset() { MaybeRef = optional_none_tag(); } bool has_value() const { return MaybeRef.hasOptionalValue(); } - bool hasValue() const { return MaybeRef.hasOptionalValue(); } + LLVM_DEPRECATED("Use has_value instead.", "has_value") bool hasValue() const { + return MaybeRef.hasOptionalValue(); + } RefTy &value() & { assert(has_value()); return MaybeRef; } - RefTy &getValue() & { + LLVM_DEPRECATED("Use value instead.", "value") RefTy &getValue() & { assert(has_value()); return MaybeRef; } @@ -145,6 +147,7 @@ public: assert(has_value()); return MaybeRef; } + LLVM_DEPRECATED("Use value instead.", "value") RefTy const &getValue() const & { assert(has_value()); return MaybeRef; @@ -153,7 +156,7 @@ public: assert(has_value()); return std::move(MaybeRef); } - RefTy &&getValue() && { + LLVM_DEPRECATED("Use value instead.", "value") RefTy &&getValue() && { assert(has_value()); return std::move(MaybeRef); } -- 2.7.4