From 8da7cc087b27c039a217c2b5b13df717bc6bbc88 Mon Sep 17 00:00:00 2001 From: Sudeep Holla Date: Mon, 20 Jun 2016 15:56:09 +0100 Subject: [PATCH] arm64: Kconfig: select PM{,_GENERIC_DOMAINS} for ARCH_VEXPRESS The Linux AMBA bus framework probes the peripheral IDs when adding the AMBA devices very early on the boot. Generally they are on APB bus and just require APB clocks to be on even when most of the core logic of the IP is powered down. However on Juno, the entire debugsys domain needs to be ON to access even the coresight components' CID/PID registers and hence broken by design. Accessing those while debugsys power domain is off will lead to the bridge stalling the transactions instead of returning the slave error. Further, the AMBA framework can't deal with !CONFIG_PM_GENERIC_DOMAINS case: it ignores the error and proceeds to access the device region. It was suggested to always enable CONFIG_PM{,_GENERIC_DOMAINS} in order to handle above explained scenario. Cc: Arnd Bergmann Suggested-by: Ulf Hansson Signed-off-by: Sudeep Holla Signed-off-by: Olof Johansson --- arch/arm64/Kconfig.platforms | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index f5e7db6..89712f7 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -163,6 +163,8 @@ config ARCH_VEXPRESS bool "ARMv8 software model (Versatile Express)" select ARCH_REQUIRE_GPIOLIB select COMMON_CLK_VERSATILE + select PM + select PM_GENERIC_DOMAINS select POWER_RESET_VEXPRESS select VEXPRESS_CONFIG help -- 2.7.4