From 8d835ec400819140e5fc8532a90010c694e1212b Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Sun, 23 Nov 2014 05:45:24 -0300 Subject: [PATCH] queue2: percentage is relative to high-percent When comparing percentage values, compare with 0-100 scale as it has already been made relative to 0-high_percent, otherwise we mark the queue as not buffering and report a 50% to the user. This leads to a buffering stall as the user assumes the queue is still buffering but it thinks it isn't. https://bugzilla.gnome.org/show_bug.cgi?id=736969 --- plugins/elements/gstqueue2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/elements/gstqueue2.c b/plugins/elements/gstqueue2.c index 3f887f0..dd862a3 100644 --- a/plugins/elements/gstqueue2.c +++ b/plugins/elements/gstqueue2.c @@ -953,7 +953,7 @@ update_buffering (GstQueue2 * queue) if (queue->is_buffering) { /* if we were buffering see if we reached the high watermark */ - if (percent >= queue->high_percent) + if (percent >= 100) queue->is_buffering = FALSE; SET_PERCENT (queue, percent); -- 2.7.4