From 8d486d1398522a6eee0d28563345630b78329b41 Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Tue, 18 Jul 2023 15:15:40 +0100 Subject: [PATCH] decodebin3: Prevent a critical warning when reassigning output slots Do not attempt to send a streams-selected message when reassigning an output slot in case upstream signalled that it is handling stream selection. In this case decodebin3 doesn't keep track of stream collections (`dbin->collection` is NULL). Part-of: --- subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c b/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c index ebe749b89c..e67a07934b 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c +++ b/subprojects/gst-plugins-base/gst/playback/gstdecodebin3.c @@ -2218,6 +2218,11 @@ is_selection_done (GstDecodebin3 * dbin) GST_LOG_OBJECT (dbin, "Checking"); + if (dbin->upstream_selected) { + GST_DEBUG ("Upstream handles stream selection, returning"); + return NULL; + } + if (dbin->to_activate != NULL) { GST_DEBUG ("Still have streams to activate"); return NULL; -- 2.34.1