From 8d3bc88bbe3c0690f433a97c1df33fca099f18be Mon Sep 17 00:00:00 2001 From: Yorkie Date: Sat, 28 Dec 2013 20:59:57 +0800 Subject: [PATCH] querystring: remove `name` from `stringify()` QueryString.stringify() allowed a fourth argument that was used as a conditional in the return value, but was undocumented, not used by core and always was always false/undefiend. So the argument and conditional have been removed. Signed-off-by: Trevor Norris --- lib/querystring.js | 7 ++----- test/simple/test-querystring.js | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/querystring.js b/lib/querystring.js index e9ff825..436789e 100644 --- a/lib/querystring.js +++ b/lib/querystring.js @@ -125,7 +125,7 @@ var stringifyPrimitive = function(v) { }; -QueryString.stringify = QueryString.encode = function(obj, sep, eq, name) { +QueryString.stringify = QueryString.encode = function(obj, sep, eq) { sep = sep || '&'; eq = eq || '='; if (util.isNull(obj)) { @@ -145,10 +145,7 @@ QueryString.stringify = QueryString.encode = function(obj, sep, eq, name) { }).join(sep); } - - if (!name) return ''; - return QueryString.escape(stringifyPrimitive(name)) + eq + - QueryString.escape(stringifyPrimitive(obj)); + return ''; }; // Parse a key=val string. diff --git a/test/simple/test-querystring.js b/test/simple/test-querystring.js index 483982c..04d085b 100644 --- a/test/simple/test-querystring.js +++ b/test/simple/test-querystring.js @@ -124,7 +124,7 @@ qsWeirdObjects.forEach(function(testCase) { }); qsNoMungeTestCases.forEach(function(testCase) { - assert.deepEqual(testCase[0], qs.stringify(testCase[1], '&', '=', false)); + assert.deepEqual(testCase[0], qs.stringify(testCase[1], '&', '=')); }); // test the nested qs-in-qs case -- 2.7.4