From 8cf7c2f9df647489fadc1db53e8be8b4af80f5dd Mon Sep 17 00:00:00 2001 From: Sergio Paracuellos Date: Sun, 20 May 2018 15:00:26 +0200 Subject: [PATCH] staging: mt7621-gpio: use MTK_BANK_WIDTH instead of magic number There are some places where magic number '32' is being used to get the gpio bank. There already exist a definition MTK_BANK_WIDTH with this value, so just use it instead. Signed-off-by: Sergio Paracuellos Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- drivers/staging/mt7621-gpio/gpio-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c index 15a1003..5d923a7 100644 --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c @@ -227,7 +227,7 @@ mediatek_gpio_irq_unmask(struct irq_data *d) { struct mtk_data *gpio_data = irq_data_get_irq_chip_data(d); int pin = d->hwirq; - int bank = pin / 32; + int bank = pin / MTK_BANK_WIDTH; struct mtk_gc *rg = gpio_data->gc_map[bank]; unsigned long flags; u32 rise, fall; @@ -249,7 +249,7 @@ mediatek_gpio_irq_mask(struct irq_data *d) { struct mtk_data *gpio_data = irq_data_get_irq_chip_data(d); int pin = d->hwirq; - int bank = pin / 32; + int bank = pin / MTK_BANK_WIDTH; struct mtk_gc *rg = gpio_data->gc_map[bank]; unsigned long flags; u32 rise, fall; @@ -271,7 +271,7 @@ mediatek_gpio_irq_type(struct irq_data *d, unsigned int type) { struct mtk_data *gpio_data = irq_data_get_irq_chip_data(d); int pin = d->hwirq; - int bank = pin / 32; + int bank = pin / MTK_BANK_WIDTH; struct mtk_gc *rg = gpio_data->gc_map[bank]; u32 mask = BIT(d->hwirq); -- 2.7.4