From 8cc7ad48d5cfac4b2dd7067f0ebee048eceb02d4 Mon Sep 17 00:00:00 2001 From: Qiang Yu Date: Mon, 15 May 2023 11:23:06 +0800 Subject: [PATCH] ac/llvm: remove the double frcp special handling MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit KHR-GL45.gpu_shader_fp64.builtin.mod_* relaxed precision requirement. Reviewed-by: Marek Olšák Signed-off-by: Qiang Yu Part-of: --- src/amd/llvm/ac_llvm_build.c | 4 ---- src/amd/llvm/ac_nir_to_llvm.c | 9 ++------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/amd/llvm/ac_llvm_build.c b/src/amd/llvm/ac_llvm_build.c index 423cedd..2dd1069 100644 --- a/src/amd/llvm/ac_llvm_build.c +++ b/src/amd/llvm/ac_llvm_build.c @@ -711,10 +711,6 @@ LLVMValueRef ac_build_fdiv(struct ac_llvm_context *ctx, LLVMValueRef num, LLVMVa unsigned type_size = ac_get_type_size(LLVMTypeOf(den)); const char *name; - /* For doubles, we need precise division to pass GLCTS. */ - if (ctx->float_mode == AC_FLOAT_MODE_DEFAULT_OPENGL && type_size == 8) - return LLVMBuildFDiv(ctx->builder, num, den, ""); - if (type_size == 2) name = "llvm.amdgcn.rcp.f16"; else if (type_size == 4) diff --git a/src/amd/llvm/ac_nir_to_llvm.c b/src/amd/llvm/ac_nir_to_llvm.c index c1b3543..3adb8b1 100644 --- a/src/amd/llvm/ac_nir_to_llvm.c +++ b/src/amd/llvm/ac_nir_to_llvm.c @@ -671,13 +671,8 @@ static bool visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr) src, 2, 0); break; case nir_op_frcp: - /* For doubles, we need precise division to pass GLCTS. */ - if (ctx->ac.float_mode == AC_FLOAT_MODE_DEFAULT_OPENGL && ac_get_type_size(def_type) == 8) { - result = LLVMBuildFDiv(ctx->ac.builder, ctx->ac.f64_1, ac_to_float(&ctx->ac, src[0]), ""); - } else { - result = emit_intrin_1f_param_scalar(&ctx->ac, "llvm.amdgcn.rcp", - ac_to_float_type(&ctx->ac, def_type), src[0]); - } + result = emit_intrin_1f_param_scalar(&ctx->ac, "llvm.amdgcn.rcp", + ac_to_float_type(&ctx->ac, def_type), src[0]); if (ctx->abi->clamp_div_by_zero) result = ac_build_fmin(&ctx->ac, result, LLVMConstReal(ac_to_float_type(&ctx->ac, def_type), FLT_MAX)); -- 2.7.4