From 8c63dc6f6dc0f905acbcbf7f67c60af8d3cbe5a2 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 13 Apr 2023 10:28:58 -0700 Subject: [PATCH] Internalize AllocationBegin functions after D147005 Reviewed By: thurston Differential Revision: https://reviews.llvm.org/D148195 --- compiler-rt/lib/asan/asan_allocator.cpp | 2 +- compiler-rt/lib/dfsan/dfsan_allocator.cpp | 2 +- compiler-rt/lib/hwasan/hwasan_allocator.cpp | 2 +- compiler-rt/lib/lsan/lsan_allocator.cpp | 2 +- compiler-rt/lib/memprof/memprof_allocator.cpp | 2 +- compiler-rt/lib/msan/msan_allocator.cpp | 2 +- compiler-rt/lib/tsan/rtl/tsan_mman.cpp | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/compiler-rt/lib/asan/asan_allocator.cpp b/compiler-rt/lib/asan/asan_allocator.cpp index 2d6a5dd..19d7777 100644 --- a/compiler-rt/lib/asan/asan_allocator.cpp +++ b/compiler-rt/lib/asan/asan_allocator.cpp @@ -1164,7 +1164,7 @@ IgnoreObjectResult IgnoreObject(const void *p) { // ---------------------- Interface ---------------- {{{1 using namespace __asan; -const void *AllocationBegin(const void *p) { +static const void *AllocationBegin(const void *p) { AsanChunk *m = __asan::instance.GetAsanChunkByAddr((uptr)p); if (!m) return nullptr; diff --git a/compiler-rt/lib/dfsan/dfsan_allocator.cpp b/compiler-rt/lib/dfsan/dfsan_allocator.cpp index 36346d1..3075b6d 100644 --- a/compiler-rt/lib/dfsan/dfsan_allocator.cpp +++ b/compiler-rt/lib/dfsan/dfsan_allocator.cpp @@ -174,7 +174,7 @@ void *DFsanCalloc(uptr nmemb, uptr size) { return DFsanAllocate(nmemb * size, sizeof(u64), true /*zeroise*/); } -const void *AllocationBegin(const void *p) { +static const void *AllocationBegin(const void *p) { if (!p) return nullptr; void *beg = allocator.GetBlockBegin(p); diff --git a/compiler-rt/lib/hwasan/hwasan_allocator.cpp b/compiler-rt/lib/hwasan/hwasan_allocator.cpp index 6760100..d3cb5c8 100644 --- a/compiler-rt/lib/hwasan/hwasan_allocator.cpp +++ b/compiler-rt/lib/hwasan/hwasan_allocator.cpp @@ -409,7 +409,7 @@ HwasanChunkView FindHeapChunkByAddress(uptr address) { return HwasanChunkView(reinterpret_cast(block), metadata); } -const void *AllocationBegin(const void *p) { +static const void *AllocationBegin(const void *p) { const void *untagged_ptr = UntagPtr(p); if (!untagged_ptr) return nullptr; diff --git a/compiler-rt/lib/lsan/lsan_allocator.cpp b/compiler-rt/lib/lsan/lsan_allocator.cpp index 8399427..ee7faca 100644 --- a/compiler-rt/lib/lsan/lsan_allocator.cpp +++ b/compiler-rt/lib/lsan/lsan_allocator.cpp @@ -145,7 +145,7 @@ void GetAllocatorCacheRange(uptr *begin, uptr *end) { *end = *begin + sizeof(AllocatorCache); } -const void *GetMallocBegin(const void *p) { +static const void *GetMallocBegin(const void *p) { if (!p) return nullptr; void *beg = allocator.GetBlockBegin(p); diff --git a/compiler-rt/lib/memprof/memprof_allocator.cpp b/compiler-rt/lib/memprof/memprof_allocator.cpp index 49c0aad..1e0d05d 100644 --- a/compiler-rt/lib/memprof/memprof_allocator.cpp +++ b/compiler-rt/lib/memprof/memprof_allocator.cpp @@ -681,7 +681,7 @@ int memprof_posix_memalign(void **memptr, uptr alignment, uptr size, return 0; } -const void *memprof_malloc_begin(const void *p) { +static const void *memprof_malloc_begin(const void *p) { u64 user_requested_size; MemprofChunk *m = instance.GetMemprofChunkByAddr((uptr)p, user_requested_size); diff --git a/compiler-rt/lib/msan/msan_allocator.cpp b/compiler-rt/lib/msan/msan_allocator.cpp index 1013303..c32a029 100644 --- a/compiler-rt/lib/msan/msan_allocator.cpp +++ b/compiler-rt/lib/msan/msan_allocator.cpp @@ -260,7 +260,7 @@ static void *MsanCalloc(StackTrace *stack, uptr nmemb, uptr size) { return MsanAllocate(stack, nmemb * size, sizeof(u64), true); } -const void *AllocationBegin(const void *p) { +static const void *AllocationBegin(const void *p) { if (!p) return nullptr; void *beg = allocator.GetBlockBegin(p); diff --git a/compiler-rt/lib/tsan/rtl/tsan_mman.cpp b/compiler-rt/lib/tsan/rtl/tsan_mman.cpp index b548265..e5271cf 100644 --- a/compiler-rt/lib/tsan/rtl/tsan_mman.cpp +++ b/compiler-rt/lib/tsan/rtl/tsan_mman.cpp @@ -352,7 +352,7 @@ void *user_pvalloc(ThreadState *thr, uptr pc, uptr sz) { return SetErrnoOnNull(user_alloc_internal(thr, pc, sz, PageSize)); } -const void *user_alloc_begin(const void *p) { +static const void *user_alloc_begin(const void *p) { if (p == nullptr || !IsAppMem((uptr)p)) return nullptr; void *beg = allocator()->GetBlockBegin(p); -- 2.7.4