From 8c1ba754cfa84a8af3d1e88b24d79a43c5ee9bbb Mon Sep 17 00:00:00 2001 From: David Herrmann Date: Sat, 10 Jan 2015 13:38:48 +0100 Subject: [PATCH] metadata: warn if collected names are ill-formatted Make sure we properly collect owned-names items, just like we verify all our other item generators. Signed-off-by: David Herrmann --- metadata.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/metadata.c b/metadata.c index 47dd52a..ad548c5 100644 --- a/metadata.c +++ b/metadata.c @@ -578,6 +578,9 @@ int kdbus_meta_add_conn_info(struct kdbus_meta *meta, item = KDBUS_ITEM_NEXT(item); } + /* sanity check: the buffer should be completely written now */ + WARN_ON((u8 *)item != (u8 *)meta->owned_names_items + size); + meta->collected |= KDBUS_ATTACH_NAMES; } -- 2.34.1