From 8bc7d71c2323645cff01b5d9245db6a65c0c7f0b Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 3 Jun 2023 16:16:41 -0700 Subject: [PATCH] pvr: Fix signed comparison Fix defect reported by Coverity Scan. Unsigned compared against 0 (NO_EFFECT) unsigned_compare: This less-than-zero comparison of an unsigned value is never true. val < 0U. unsigned_conversion: val is converted to an unsigned type because it's compared to an unsigned constant. Fixes: 480bdff4b52 ("pvr: Add support to process transfer and blit cmds") Signed-off-by: Vinson Lee Reviewed-by: Karmjit Mahil Part-of: --- src/imagination/vulkan/pvr_job_transfer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/imagination/vulkan/pvr_job_transfer.c b/src/imagination/vulkan/pvr_job_transfer.c index 0afcf36..6c3e350 100644 --- a/src/imagination/vulkan/pvr_job_transfer.c +++ b/src/imagination/vulkan/pvr_job_transfer.c @@ -3504,7 +3504,7 @@ pvr_int32_to_isp_xy_vtx(const struct pvr_device_info *dev_info, return vk_error(NULL, VK_ERROR_UNKNOWN); pvr_csb_pack (word_out, IPF_ISP_VERTEX_XY, word) { - word.sign = val < 0U; + word.sign = val < 0; word.integer = val; } -- 2.7.4