From 8bbd06c7c61e874ed89672f76fee2b237c285d8e Mon Sep 17 00:00:00 2001 From: Mathieu Duponchelle Date: Fri, 29 Jan 2021 20:42:26 +0100 Subject: [PATCH] ges-launcher: do not set rendering details too early It looks like the _set_rendering_details call is superfluous in _startup(), as it will get called in run_pipeline. The problem with calling it before timeline_set_user_options is that we are going to fail creating a smart profile if the user selected eg --track-types=video, as the get_smart_profile method compares the tracks in the asset with those on the timeline. Reproduce with a video-only clip: ges-launch-1.0 --track-types=video +clip file://$PWD/jelly.mp4 \ inpoint=15.0 -o foo.mp4 --smart-rendering Part-of: --- tools/ges-launcher.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/ges-launcher.c b/tools/ges-launcher.c index cf56b83..f0a6de2 100644 --- a/tools/ges-launcher.c +++ b/tools/ges-launcher.c @@ -1450,9 +1450,6 @@ _startup (GApplication * application) if (!_set_playback_details (self)) goto failure; - if (!_set_rendering_details (self)) - goto failure; - if (!_run_pipeline (self)) goto failure; -- 2.7.4