From 8b95d17f75f2959175c387307be7449d752bef09 Mon Sep 17 00:00:00 2001 From: Wonchul Lee Date: Mon, 17 Oct 2016 15:38:37 +0900 Subject: [PATCH] playbin3: Fix deadlock when adding multiple parsebin https://bugzilla.gnome.org/show_bug.cgi?id=773131 --- gst/playback/gstplaybin3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gst/playback/gstplaybin3.c b/gst/playback/gstplaybin3.c index fdf0c82..3c5bd47 100644 --- a/gst/playback/gstplaybin3.c +++ b/gst/playback/gstplaybin3.c @@ -4523,6 +4523,7 @@ urisrc_pad_added (GstElement * urisrc, GstPad * pad, GstSourceGroup * group) sinkpad = NULL; } } + GST_SOURCE_GROUP_UNLOCK (group); if (sinkpad == NULL) { /* Auxiliary stream, request a new pad from decodebin */ @@ -4541,7 +4542,6 @@ urisrc_pad_added (GstElement * urisrc, GstPad * pad, GstSourceGroup * group) if (GST_PAD_LINK_FAILED (res)) goto link_failed; } - GST_SOURCE_GROUP_UNLOCK (group); return; link_failed: @@ -4549,7 +4549,6 @@ link_failed: GST_ERROR_OBJECT (playbin, "failed to link pad %s:%s to decodebin, reason %s (%d)", GST_DEBUG_PAD_NAME (pad), gst_pad_link_get_name (res), res); - GST_SOURCE_GROUP_UNLOCK (group); return; } } -- 2.7.4