From 8ae4842669f1fee33d22cc3f0c895c7839d05aef Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Fri, 2 Oct 2020 18:19:51 -0700 Subject: [PATCH] [X86] Move MWAITX_DAG ISD opcode so it is not in the strict FP range. Add a comment to hopefully prevent anyone else from making the same mistake. --- llvm/lib/Target/X86/X86ISelLowering.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/llvm/lib/Target/X86/X86ISelLowering.h b/llvm/lib/Target/X86/X86ISelLowering.h index 7c977ce..f8de2f7 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.h +++ b/llvm/lib/Target/X86/X86ISelLowering.h @@ -710,6 +710,9 @@ namespace llvm { // For avx512-vp2intersect VP2INTERSECT, + // Mwaitx builtin is lowered to this if the base pointer needs saving. + MWAITX_DAG, + /// X86 strict FP compare instructions. STRICT_FCMP = ISD::FIRST_TARGET_STRICTFP_OPCODE, STRICT_FCMPS, @@ -749,8 +752,8 @@ namespace llvm { STRICT_CVTPS2PH, STRICT_CVTPH2PS, - // Mwaitx builtin is lowered to this if the base pointer needs saving. - MWAITX_DAG, + // WARNING: Only add nodes here if they are stric FP nodes. Non-memory and + // non-strict FP nodes should be above FIRST_TARGET_STRICTFP_OPCODE. // Compare and swap. LCMPXCHG_DAG = ISD::FIRST_TARGET_MEMORY_OPCODE, -- 2.7.4