From 8ae2c2bb1d4d9701234a867709509878625ffbb2 Mon Sep 17 00:00:00 2001 From: Bowon Ryu Date: Tue, 2 Oct 2018 19:24:28 +0900 Subject: [PATCH] efl_page_transition_scroll: fix warning the dereference before null check Summary: if target is null, then terminate the function because it is not intended. Test Plan: N/A Reviewers: eunue Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7127 Change-Id: Ia7f78e5a8a5e246623afee94231cc128df88d965 Signed-off-by: Bowon Ryu --- src/lib/elementary/efl_page_transition_scroll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/elementary/efl_page_transition_scroll.c b/src/lib/elementary/efl_page_transition_scroll.c index ab93d7c..41b7033 100644 --- a/src/lib/elementary/efl_page_transition_scroll.c +++ b/src/lib/elementary/efl_page_transition_scroll.c @@ -405,6 +405,8 @@ _efl_page_transition_scroll_curr_page_change(Eo *obj EINA_UNUSED, } pi->pos = pi->id - (pd->side_page_num + 1); + if (!target) return; + EINA_RECTANGLE_SET(&pi->temp, target->geometry.x, target->geometry.y, -- 2.7.4