From 8ada7f23c813112332b3f499d58aa6bba5b0faeb Mon Sep 17 00:00:00 2001 From: "haraken@chromium.org" Date: Thu, 2 Feb 2012 08:23:59 +0000 Subject: [PATCH] The third argument of addEventListener/removeEventListener of PeerConnection should be optional https://bugs.webkit.org/show_bug.cgi?id=77606 Reviewed by Adam Barth. Source/WebCore: This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional]. Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html * mediastream/PeerConnection.idl: LayoutTests: The added test confirms if the third argument of addEventListener() and removeEventListener() is optional. * fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added. * fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106539 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 13 +++++++++++ ...on-eventlistener-optional-argument-expected.txt | 15 +++++++++++++ ...connection-eventlistener-optional-argument.html | 25 ++++++++++++++++++++++ Source/WebCore/ChangeLog | 13 +++++++++++ Source/WebCore/mediastream/PeerConnection.idl | 4 ++-- 5 files changed, 68 insertions(+), 2 deletions(-) create mode 100644 LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt create mode 100644 LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument.html diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 0f0713f..ebed4b8 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,16 @@ +2012-02-02 Kentaro Hara + + The third argument of addEventListener/removeEventListener of PeerConnection should be optional + https://bugs.webkit.org/show_bug.cgi?id=77606 + + Reviewed by Adam Barth. + + The added test confirms if the third argument of addEventListener() and + removeEventListener() is optional. + + * fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added. + * fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added. + 2012-02-01 Philippe Normand [GStreamer] FFTFrame implementation diff --git a/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt b/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt new file mode 100644 index 0000000..84ac1ab --- /dev/null +++ b/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt @@ -0,0 +1,15 @@ +This test confirms if the third argument of addEventListener() and removeEventListener() is optional. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS pc.addEventListener("foo", function() {}) is undefined +PASS pc.addEventListener("foo", function() {}, false) is undefined +PASS pc.addEventListener("foo", function() {}, true) is undefined +PASS pc.removeEventListener("foo", function() {}) is undefined +PASS pc.removeEventListener("foo", function() {}, false) is undefined +PASS pc.removeEventListener("foo", function() {}, true) is undefined +PASS successfullyParsed is true + +TEST COMPLETE + diff --git a/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument.html b/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument.html new file mode 100644 index 0000000..6175ee7 --- /dev/null +++ b/LayoutTests/fast/mediastream/peerconnection-eventlistener-optional-argument.html @@ -0,0 +1,25 @@ + + + + + + +

+ + + + diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 5093ee8..f0dbcba 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,16 @@ +2012-02-02 Kentaro Hara + + The third argument of addEventListener/removeEventListener of PeerConnection should be optional + https://bugs.webkit.org/show_bug.cgi?id=77606 + + Reviewed by Adam Barth. + + This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional]. + + Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html + + * mediastream/PeerConnection.idl: + 2012-02-02 Rakesh KN hidden attribute on suppresses the file selection dialog diff --git a/Source/WebCore/mediastream/PeerConnection.idl b/Source/WebCore/mediastream/PeerConnection.idl index f9ee192..59d35e3 100644 --- a/Source/WebCore/mediastream/PeerConnection.idl +++ b/Source/WebCore/mediastream/PeerConnection.idl @@ -64,10 +64,10 @@ module p2p { // EventTarget interface void addEventListener(in DOMString type, in EventListener listener, - in [optional] boolean useCapture); + in [Optional] boolean useCapture); void removeEventListener(in DOMString type, in EventListener listener, - in [optional] boolean useCapture); + in [Optional] boolean useCapture); boolean dispatchEvent(in Event event) raises(EventException); }; -- 2.7.4