From 8a2cfdfbf5756afff4a0a8dc852d8a478f3e3365 Mon Sep 17 00:00:00 2001 From: Alexey Gladkov Date: Mon, 12 Feb 2007 11:32:21 +0300 Subject: [PATCH] [BUILD] Fix build warnings Add missing headers and check return codes to avoid warnings at the build time. Signed-off-by: Alexey Gladkov --- src/kbdrate.c | 22 +++++++++++++++++----- src/spawn_console.c | 9 +++++++-- src/spawn_login.c | 15 ++++++++++++--- 3 files changed, 36 insertions(+), 10 deletions(-) diff --git a/src/kbdrate.c b/src/kbdrate.c index 9a612b2..e76bdf9 100644 --- a/src/kbdrate.c +++ b/src/kbdrate.c @@ -202,7 +202,7 @@ KIOCSRATE_ioctl_ok(double rate, int delay, int silent) { #endif /* KIOCSRATE */ } -void +static void sigalrmhandler( int sig ) { fprintf( stderr, "kbdrate: Failed waiting for kbd controller!\n" ); raise( SIGINT ); @@ -289,23 +289,35 @@ main( int argc, char **argv ) { do { lseek( fd, 0x64, 0 ); - read( fd, &data, 1 ); + if (read( fd, &data, 1 ) == -1) { + perror( "read" ); + exit( 1 ); + } } while ((data & 2) == 2 ); /* wait */ lseek( fd, 0x60, 0 ); data = 0xf3; /* set typematic rate */ - write( fd, &data, 1 ); + if (write( fd, &data, 1 ) == -1) { + perror( "write" ); + exit( 1 ); + } do { lseek( fd, 0x64, 0 ); - read( fd, &data, 1 ); + if (read( fd, &data, 1 ) == -1) { + perror( "read" ); + exit( 1 ); + } } while ((data & 2) == 2 ); /* wait */ alarm( 0 ); lseek( fd, 0x60, 0 ); sleep( 1 ); - write( fd, &value, 1 ); + if (write( fd, &value, 1 ) == -1) { + perror( "write" ); + exit( 1 ); + } close( fd ); diff --git a/src/spawn_console.c b/src/spawn_console.c index 97bee45..0904ef9 100644 --- a/src/spawn_console.c +++ b/src/spawn_console.c @@ -12,6 +12,7 @@ #include #include #include +#include #include /* system */ #include /* open */ #include /* ioctl */ @@ -19,11 +20,15 @@ void sighup(){ - system("openvt -s -l bash"); + if (system("openvt -s -l bash") == -1) { + perror("system"); + exit(1); + } signal(SIGHUP, sighup); } -main(){ +int +main(void) { int fd; fd = open("/dev/tty0", 0); diff --git a/src/spawn_login.c b/src/spawn_login.c index 0cbb1dd..1cbf8f4 100644 --- a/src/spawn_login.c +++ b/src/spawn_login.c @@ -4,17 +4,26 @@ * aeb - 941025 * */ +#include +#include #include #include +#include +#include +#include #include void -sighup(){ - system("openvt -s -l -- login -h spawn"); +sighup() { + if (system("openvt -s -l -- login -h spawn") == -1) { + perror("system"); + exit(1); + } signal(SIGHUP, sighup); } -main(){ +int +main(void) { int fd; fd = open("/dev/tty0", 0); -- 2.7.4