From 899bbf310b5fb63f3aad96fde9fce0308039a386 Mon Sep 17 00:00:00 2001 From: Sreerenj Balachandran Date: Sat, 13 Apr 2013 19:43:10 +0300 Subject: [PATCH] pluginfeature: Fix the GstPluginFeature name comparison. The gst_plugin_feature_rank_compare_func() should return negative value, if the rank of both PluginFeatures are equal and the name of first PluginFeature comes before the second one. https://bugzilla.gnome.org/show_bug.cgi?id=697990 --- gst/gstpluginfeature.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/gstpluginfeature.c b/gst/gstpluginfeature.c index a602b53..6dd5e56 100644 --- a/gst/gstpluginfeature.c +++ b/gst/gstpluginfeature.c @@ -382,7 +382,7 @@ gst_plugin_feature_check_version (GstPluginFeature * feature, * Returns: negative value if the rank of p1 > the rank of p2 or the ranks are * equal but the name of p1 comes before the name of p2; zero if the rank * and names are equal; positive value if the rank of p1 < the rank of p2 or the - * ranks are equal but the name of p2 comes after the name of p1 + * ranks are equal but the name of p2 comes before the name of p1 */ gint gst_plugin_feature_rank_compare_func (gconstpointer p1, gconstpointer p2) @@ -397,7 +397,7 @@ gst_plugin_feature_rank_compare_func (gconstpointer p1, gconstpointer p2) if (diff != 0) return diff; - diff = strcmp (GST_OBJECT_NAME (f2), GST_OBJECT_NAME (f1)); + diff = strcmp (GST_OBJECT_NAME (f1), GST_OBJECT_NAME (f2)); return diff; } -- 2.7.4