From 894b730164d2f7bde661da448e10af367ed99639 Mon Sep 17 00:00:00 2001 From: Tomas Weinfurt Date: Sun, 8 Nov 2020 07:14:14 -0800 Subject: [PATCH] change using in ConnectCallback_UseUnixDomainSocket_Success (#44366) --- .../FunctionalTests/SocketsHttpHandlerTest.cs | 26 +++++++++++++--------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs index 0f43cf0..84147ea 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs @@ -2476,22 +2476,26 @@ namespace System.Net.Http.Functional.Tests return new NetworkStream(clientSocket, ownsSocket: true); }; - using HttpClient client = CreateHttpClient(handler); - client.DefaultVersionPolicy = HttpVersionPolicy.RequestVersionExact; + using (HttpClient client = CreateHttpClient(handler)) + { + client.DefaultVersionPolicy = HttpVersionPolicy.RequestVersionExact; - Task clientTask = client.GetStringAsync($"{(options.UseSsl ? "https" : "http")}://{guid}/foo"); + Task clientTask = client.GetStringAsync($"{(options.UseSsl ? "https" : "http")}://{guid}/foo"); - Socket serverSocket = await listenSocket.AcceptAsync(); - using GenericLoopbackConnection loopbackConnection = await LoopbackServerFactory.CreateConnectionAsync(socket: null, new NetworkStream(serverSocket, ownsSocket: true), options); - await loopbackConnection.InitializeConnectionAsync(); + Socket serverSocket = await listenSocket.AcceptAsync(); + using (GenericLoopbackConnection loopbackConnection = await LoopbackServerFactory.CreateConnectionAsync(socket: null, new NetworkStream(serverSocket, ownsSocket: true), options)) + { + await loopbackConnection.InitializeConnectionAsync(); - HttpRequestData requestData = await loopbackConnection.ReadRequestDataAsync(); - Assert.Equal("/foo", requestData.Path); + HttpRequestData requestData = await loopbackConnection.ReadRequestDataAsync(); + Assert.Equal("/foo", requestData.Path); - await loopbackConnection.SendResponseAsync(content: "foo"); + await loopbackConnection.SendResponseAsync(content: "foo"); - string response = await clientTask; - Assert.Equal("foo", response); + string response = await clientTask; + Assert.Equal("foo", response); + } + } } [Theory] -- 2.7.4