From 88d605bdedbdc92c1b1a190e0a2c99efbdab35e6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Fri, 20 Jun 2008 11:07:05 +0000 Subject: [PATCH] docs/design/Makefile.am: Dist some more design docs. Original commit message from CVS: * docs/design/Makefile.am: Dist some more design docs. * docs/random/moving-plugins: Small addition: good plugins mustn't have functional code within assertion macros. --- ChangeLog | 15 +++++++++++++++ docs/design/Makefile.am | 2 ++ docs/random/moving-plugins | 4 ++++ 3 files changed, 21 insertions(+) diff --git a/ChangeLog b/ChangeLog index bc6c93f..3021a7a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2008-06-20 Tim-Philipp Müller + + * docs/design/Makefile.am: + Dist some more design docs. + + * docs/random/moving-plugins: + Small addition: good plugins mustn't have functional code + within assertion macros. + 2008-06-20 Wim Taymans * docs/design/draft-framestep.txt: @@ -9,6 +18,12 @@ 2008-06-20 Tim-Philipp Müller + * gst/gsttaglist.h: + In GST_TAG_ATTACHEMENT docs, mention that the file name needs to + be in UTF-8 encoding. + +2008-06-20 Tim-Philipp Müller + * gst/gstbus.c: Make it known that gst_bus_poll() is pure evil (fixes #538810). diff --git a/docs/design/Makefile.am b/docs/design/Makefile.am index a2fdb3f..ba441e8 100644 --- a/docs/design/Makefile.am +++ b/docs/design/Makefile.am @@ -1,10 +1,12 @@ EXTRA_DIST = \ + draft-framestep.txt \ draft-ghostpads.txt \ draft-klass.txt \ draft-latency.txt \ draft-missing-plugins.txt \ draft-push-pull.txt \ + draft-tagreading.txt \ part-activation.txt \ part-block.txt \ part-buffering.txt \ diff --git a/docs/random/moving-plugins b/docs/random/moving-plugins index bd48dbf..e994cac 100644 --- a/docs/random/moving-plugins +++ b/docs/random/moving-plugins @@ -55,6 +55,10 @@ CHECKLIST e.g.: GST_BASE_SINK, GstBaseSink, gst_base_sink_ - use g_assert(), g_return_if_fail(), g_return_val_if_fail() for pre/post condition checks + - must not have any functional code within g_assert(), g_return_if_fail() or + g_return_val_if_fail() statements, since those would be turned into NO-OPS + if the code is compiled with -DG_DISABLE_CHECKS (as is often done on + embedded systems). - The plug-in's build: - should be correctly integrated with configure.ac -- 2.7.4