From 8883d20d688dc7ff8bb58afbb6e6babd00acf5bb Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EB=B0=95=EC=A2=85=ED=98=84/On-Device=20Lab=28SR=29/Staff?= =?utf8?q?=20Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Fri, 1 Feb 2019 10:43:21 +0900 Subject: [PATCH] [coco.core] Explicitly specify link visibility (#2978) This commit specifies link visibility over dependent libraries. Signed-off-by: Jonghyun Park --- contrib/coco/core/CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contrib/coco/core/CMakeLists.txt b/contrib/coco/core/CMakeLists.txt index ddbdaa2..0eafe44 100644 --- a/contrib/coco/core/CMakeLists.txt +++ b/contrib/coco/core/CMakeLists.txt @@ -4,9 +4,9 @@ list(REMOVE_ITEM SOURCES ${TESTS}) add_library(coco_core SHARED ${SOURCES}) target_include_directories(coco_core PUBLIC include) -target_link_libraries(coco_core nncc_core) -# TODO Set this as PRIVATE dependency -target_link_libraries(coco_core stdex) +# NOTE Some coco_core PUBLIC headers include nncc_core headers +target_link_libraries(coco_core PUBLIC nncc_core) +target_link_libraries(coco_core PRIVATE stdex) nncc_find_package(GTest QUIET) @@ -18,3 +18,4 @@ nncc_include(OptionalTargetTools) coco_add_test(coco_core_test ${TESTS}) optional_target_link_libraries(coco_core_test coco_core) +optional_target_link_libraries(coco_core_test stdex) -- 2.7.4