From 88560678907fe683294d07e73bc1ddc99f898f05 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gy=C3=B6rgy=20Straub?= Date: Wed, 29 Jul 2020 10:55:48 +0100 Subject: [PATCH] RenderTaskProcessor::AddRenderablesForTask() optimization. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit - pulled loop-invariant conditional for which RenderableContainer to add to, out of the loop; - replaced branch for assigning true, with compound or-assignment of the result of the check; Change-Id: I2f36f2b7a5eb95da6e3cc04bddfbede0f8437b69 Signed-off-by: György Straub --- dali/internal/update/manager/render-task-processor.cpp | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/dali/internal/update/manager/render-task-processor.cpp b/dali/internal/update/manager/render-task-processor.cpp index 0079c2c..f74337b 100644 --- a/dali/internal/update/manager/render-task-processor.cpp +++ b/dali/internal/update/manager/render-task-processor.cpp @@ -167,24 +167,14 @@ bool AddRenderablesForTask( BufferIndex updateBufferIndex, // Set the information in the node. node.SetClippingInformation( currentClippingId, clippingDepth, scissorDepth ); + RenderableContainer& target = DALI_LIKELY( inheritedDrawMode == DrawMode::NORMAL ) ? + layer->colorRenderables : layer->overlayRenderables; for( uint32_t i = 0; i < count; ++i ) { SceneGraph::Renderer* renderer = node.GetRendererAt( i ); + target.PushBack( Renderable( &node, renderer ) ); - // Normal is the more-likely draw mode to occur. - if( DALI_LIKELY( inheritedDrawMode == DrawMode::NORMAL ) ) - { - layer->colorRenderables.PushBack( Renderable( &node, renderer ) ); - } - else - { - layer->overlayRenderables.PushBack( Renderable( &node, renderer ) ); - } - - if( renderer->GetRenderingBehavior() == DevelRenderer::Rendering::CONTINUOUSLY ) - { - keepRendering = true; - } + keepRendering = keepRendering || ( renderer->GetRenderingBehavior() == DevelRenderer::Rendering::CONTINUOUSLY ); } // Recurse children. -- 2.7.4