From 880e4768c20b99b1f9a50f35c180f8522dd82c9a Mon Sep 17 00:00:00 2001 From: Alper Nebi Yasak Date: Mon, 7 Jun 2021 21:11:37 +0300 Subject: [PATCH] tools: Fix default target compile tools in Python tools In commit 1e4687aa47ed ("binman: Use target-specific tools when cross-compiling"), a utility function was implemented to get preferred compilation tools using environment variables like CC and CROSS_COMPILE. Although it intended to provide custom default tools (same as those in the global Makefile) when no relevant variables were set (for example using "gcc" for "cc"), it is only doing so when CROSS_COMPILE is set and returning the literal name of the tool otherwise. Remove the check for an empty CROSS_COMPILE, which makes the function use it as an empty prefix to the custom defaults and return the intended executables. Fixes: 1e4687aa47ed ("binman: Use target-specific tools when cross-compiling") Signed-off-by: Alper Nebi Yasak --- tools/patman/tools.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/patman/tools.py b/tools/patman/tools.py index e5f391b..ec95a54 100644 --- a/tools/patman/tools.py +++ b/tools/patman/tools.py @@ -292,8 +292,6 @@ def GetTargetCompileTool(name, cross_compile=None): if cross_compile is None: cross_compile = env.get('CROSS_COMPILE', '') - if not cross_compile: - return name, [] if name in ('as', 'ar', 'nm', 'ldr', 'strip', 'objcopy', 'objdump'): target_name = cross_compile + name -- 2.7.4