From 87b12327c3356ac8233cb5a08260625221239153 Mon Sep 17 00:00:00 2001 From: Jee-Yong Um Date: Tue, 19 Apr 2016 13:59:59 +0900 Subject: [PATCH] genlist: scroll to item when calc is done Summary: If elm_genlist_item_bring_in() is called immediately after appending item, genlist will not scroll to the last one but stop in the middle. This patch blocks genlist from scrolling to not calculated item. Test Plan: 1. Uncompress attached file 2. make 3. ./test Reviewers: cedric, SanghyeonLee Reviewed By: SanghyeonLee Subscribers: jpeg Differential Revision: https://phab.enlightenment.org/D3861 --- src/lib/elementary/elm_genlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index f204537..1e8ec97 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -582,6 +582,9 @@ _item_scroll(Elm_Genlist_Data *sd) dw = it->item->block->w; dh = oh; + // hold on scrolling to item until block size calculation is finished. + if (dw < 1) return; + switch (sd->scroll_to_type) { case ELM_GENLIST_ITEM_SCROLLTO_TOP: -- 2.7.4