From 878f27741f7eb8bb918ce82934d27fe7765abc82 Mon Sep 17 00:00:00 2001 From: Rob Herring Date: Fri, 14 Jul 2023 11:50:48 -0600 Subject: [PATCH] sbus: Explicitly include correct DT includes The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Acked-by: Sam Ravnborg Link: https://lore.kernel.org/r/20230714175048.4066006-1-robh@kernel.org Signed-off-by: Rob Herring --- drivers/sbus/char/bbc_envctrl.c | 2 +- drivers/sbus/char/bbc_i2c.c | 3 ++- drivers/sbus/char/bbc_i2c.h | 1 - drivers/sbus/char/display7seg.c | 2 +- drivers/sbus/char/envctrl.c | 2 +- drivers/sbus/char/flash.c | 2 +- drivers/sbus/char/uctrl.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/sbus/char/bbc_envctrl.c b/drivers/sbus/char/bbc_envctrl.c index 4f2dd21..23af4ed 100644 --- a/drivers/sbus/char/bbc_envctrl.c +++ b/drivers/sbus/char/bbc_envctrl.c @@ -9,8 +9,8 @@ #include #include #include +#include #include -#include #include #include "bbc_i2c.h" diff --git a/drivers/sbus/char/bbc_i2c.c b/drivers/sbus/char/bbc_i2c.c index 537e55c..1c76e27 100644 --- a/drivers/sbus/char/bbc_i2c.c +++ b/drivers/sbus/char/bbc_i2c.c @@ -14,7 +14,8 @@ #include #include #include -#include +#include +#include #include #include diff --git a/drivers/sbus/char/bbc_i2c.h b/drivers/sbus/char/bbc_i2c.h index c2d066d..7ffe908 100644 --- a/drivers/sbus/char/bbc_i2c.h +++ b/drivers/sbus/char/bbc_i2c.h @@ -3,7 +3,6 @@ #define _BBC_I2C_H #include -#include #include struct bbc_i2c_client { diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index 5368b6b..18e6f84 100644 --- a/drivers/sbus/char/display7seg.c +++ b/drivers/sbus/char/display7seg.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include /* put_/get_user */ #include diff --git a/drivers/sbus/char/envctrl.c b/drivers/sbus/char/envctrl.c index ea914a7..3dd7274 100644 --- a/drivers/sbus/char/envctrl.c +++ b/drivers/sbus/char/envctrl.c @@ -28,7 +28,7 @@ #include #include #include -#include +#include #include #include diff --git a/drivers/sbus/char/flash.c b/drivers/sbus/char/flash.c index 3adfef2..ea2d903 100644 --- a/drivers/sbus/char/flash.c +++ b/drivers/sbus/char/flash.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include diff --git a/drivers/sbus/char/uctrl.c b/drivers/sbus/char/uctrl.c index 05de0ce..0660425 100644 --- a/drivers/sbus/char/uctrl.c +++ b/drivers/sbus/char/uctrl.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include -- 2.7.4