From 876d3b5a3a17e0c89bb9d7e9e486e229d8a9f5a0 Mon Sep 17 00:00:00 2001 From: David Mason Date: Tue, 16 Jun 2020 17:51:38 -0700 Subject: [PATCH] comments --- src/coreclr/src/debug/daccess/request.cpp | 2 -- src/coreclr/src/gc/gcinterface.dac.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/src/debug/daccess/request.cpp b/src/coreclr/src/debug/daccess/request.cpp index f5ab3a1..f5e362d 100644 --- a/src/coreclr/src/debug/daccess/request.cpp +++ b/src/coreclr/src/debug/daccess/request.cpp @@ -4603,7 +4603,6 @@ HRESULT ClrDataAccess::GetGenerationTableSvr(CLRDATA_ADDRESS heapAddr, unsigned HRESULT hr = S_OK; #ifdef FEATURE_SVR_GC - // NUMBERGENERATIONS is hardcoded to the previous number of generations, doesn't account for POH unsigned int numGenerationTableEntries = (unsigned int)(g_gcDacGlobals->total_generation_count); if (pNeeded != NULL) { @@ -4648,7 +4647,6 @@ HRESULT ClrDataAccess::GetFinalizationFillPointersSvr(CLRDATA_ADDRESS heapAddr, HRESULT hr = S_OK; #ifdef FEATURE_SVR_GC - // NUMBERGENERATIONS is hardcoded to the previous number of generations, doesn't account for POH unsigned int numFillPointers = (unsigned int)(g_gcDacGlobals->total_generation_count + dac_finalize_queue::ExtraSegCount); if (pNeeded != NULL) { diff --git a/src/coreclr/src/gc/gcinterface.dac.h b/src/coreclr/src/gc/gcinterface.dac.h index 647e745..0af0d42 100644 --- a/src/coreclr/src/gc/gcinterface.dac.h +++ b/src/coreclr/src/gc/gcinterface.dac.h @@ -18,6 +18,8 @@ #define MAX_GC_MECHANISM_BITS_COUNT 2 #define MAX_GLOBAL_GC_MECHANISMS_COUNT 6 +// The number of generations is hardcoded in to the dac APIS (DacpGcHeapDetails hard codes the size of its arrays) +// this cannot change #define NUMBERGENERATIONS 4 #define INITIAL_HANDLE_TABLE_ARRAY_SIZE 10 #define HANDLE_MAX_INTERNAL_TYPES 12 -- 2.7.4